[Lldb-commits] [lldb] r260366 - Add new option to lldb-server to display its version

2016-02-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Feb 10 04:35:48 2016 New Revision: 260366 URL: http://llvm.org/viewvc/llvm-project?rev=260366&view=rev Log: Add new option to lldb-server to display its version Modified: lldb/trunk/tools/lldb-server/lldb-server.cpp Modified: lldb/trunk/tools/lldb-server/lldb-se

Re: [Lldb-commits] [PATCH] D17030: Add new option to lldb-server to display its version

2016-02-10 Thread Tamas Berghammer via lldb-commits
tberghammer closed this revision. tberghammer added a comment. Comitted as http://reviews.llvm.org/rL260366 http://reviews.llvm.org/D17030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260367: Use BKPT instead of UDF for arm/thumb breakpoints (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16853?vs=46899&id=47431#toc Repository: rL LLVM http://reviews.

[Lldb-commits] [lldb] r260368 - Fix handling of the arm IT instruction in the unwinder

2016-02-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Feb 10 04:42:13 2016 New Revision: 260368 URL: http://llvm.org/viewvc/llvm-project?rev=260368&view=rev Log: Fix handling of the arm IT instruction in the unwinder The IT instruction can specify condition code for up to 4 consecutive instruction and it is used quite o

[Lldb-commits] [lldb] r260367 - Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Feb 10 04:42:00 2016 New Revision: 260367 URL: http://llvm.org/viewvc/llvm-project?rev=260367&view=rev Log: Use BKPT instead of UDF for arm/thumb breakpoints The UDF instruction is deprecated in armv7 and in case of thumb2 instructions set it don't work well together

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

2016-02-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260368: Fix handling of the arm IT instruction in the unwinder (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16814?vs=46764&id=47432#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r260369 - Improve the handling of missing elf symtab and missing symbol sizes

2016-02-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Feb 10 04:43:34 2016 New Revision: 260369 URL: http://llvm.org/viewvc/llvm-project?rev=260369&view=rev Log: Improve the handling of missing elf symtab and missing symbol sizes * Generate artificial symbol names from eh_fame during symbol parsing so these symbols ar

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-10 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260369: Improve the handling of missing elf symtab and missing symbol sizes (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16996?vs=47314&id=47433#toc Repository: rL LLV

[Lldb-commits] [lldb] r260372 - [RenderScript] Refactor allocation expressions

2016-02-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Feb 10 05:23:27 2016 New Revision: 260372 URL: http://llvm.org/viewvc/llvm-project?rev=260372&view=rev Log: [RenderScript] Refactor allocation expressions Patch refractors RS plugin code specifying how format strings are used to JIT the runtime. Author: Dean De L

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-10 Thread Luke Drummond via lldb-commits
ldrumm added a comment. In http://reviews.llvm.org/D17027#347487, @jingham wrote: > This seems fine as a generic instrumentation point. Obviously, the onus in > on the passes, since they could totally ruin the expression evaluation if > they don't do their job right... But I'm not sure ther

[Lldb-commits] [lldb] r260377 - Revert "Improve the handling of missing elf symtab and missing symbol sizes"

2016-02-10 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Feb 10 06:10:58 2016 New Revision: 260377 URL: http://llvm.org/viewvc/llvm-project?rev=260377&view=rev Log: Revert "Improve the handling of missing elf symtab and missing symbol sizes" This reverts commit 252dda67782f2cbf838e375bce21ed4191f6d9ce. The commit caused s

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-10 Thread Luke Drummond via lldb-commits
ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi This patch is on an out of date ClangExpressionParser.cpp. The feature added in http://reviews.llvm.org/rL259644 allows a more generic way of implementing what I believe you're trying to achieve with this patch. It's probably worth a

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-10 Thread Jim Ingham via lldb-commits
> On Feb 10, 2016, at 3:45 AM, Luke Drummond wrote: > > ldrumm added a comment. > > > > In http://reviews.llvm.org/D17027#347487, @jingham wrote: > >> This seems fine as a generic instrumentation point. Obviously, the onus in >> on the passes, since they could totally ruin the expression e

Re: [Lldb-commits] [lldb] r260352 - This is an idea to make "thread step-in --target" work for the common

2016-02-10 Thread Jim Ingham via lldb-commits
> On Feb 9, 2016, at 7:40 PM, Zachary Turner wrote: > > Seems like kind of an obscure command. Why not just set a one-shot > breakpoint on foo by name, then continue, so that the first time the > breakpoint hits it gets removed. > Maybe obscure, but not that hard to type, so it isn't onerou

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-10 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. As Zach said, you could add a function to ArchSpec like: std::string ArchSpec::GetClangTargetCPU(); and move your code from the large switch statement into there. It can return an empty string for any architecture that d

[Lldb-commits] [PATCH] D17088: Add target and host platform enums so we're not using strings everywhere

2016-02-10 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: tfiala, labath, tberghammer. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. The original motivation for this came when I tried to combine two decorators: ``` @expectedFailureDarwin @expec

[Lldb-commits] [lldb] r260423 - Remove skipUnlessListedRemote.

2016-02-10 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Feb 10 13:53:45 2016 New Revision: 260423 URL: http://llvm.org/viewvc/llvm-project?rev=260423&view=rev Log: Remove skipUnlessListedRemote. This was supposed to have been removed but made it back in accidentally. Modified: lldb/trunk/packages/Python/lldbsuite/test/de

[Lldb-commits] [lldb] r260422 - Remove expectedFailureLinux decorator.

2016-02-10 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Feb 10 13:53:36 2016 New Revision: 260422 URL: http://llvm.org/viewvc/llvm-project?rev=260422&view=rev Log: Remove expectedFailureLinux decorator. Modified: lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py lldb/trunk/packages/Pyth

Re: [Lldb-commits] [lldb] r260422 - Remove expectedFailureLinux decorator.

2016-02-10 Thread Siva Chandra via lldb-commits
> Modified: > lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py?rev=260422&r1=260421&r2=260422&view=diff > =

Re: [Lldb-commits] [lldb] r260422 - Remove expectedFailureLinux decorator.

2016-02-10 Thread Zachary Turner via lldb-commits
Sorry, that was a copy paste error. I will fix it. On Wed, Feb 10, 2016 at 12:56 PM Siva Chandra wrote: > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py > > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/module

[Lldb-commits] [lldb] r260434 - Now that SymbolFileDWARF supports having types in completely separate .pcm file with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF info by look

2016-02-10 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Feb 10 15:28:13 2016 New Revision: 260434 URL: http://llvm.org/viewvc/llvm-project?rev=260434&view=rev Log: Now that SymbolFileDWARF supports having types in completely separate .pcm file with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF info

[Lldb-commits] [lldb] r260436 - No reason for these two letters to be uppercase

2016-02-10 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Feb 10 15:30:20 2016 New Revision: 260436 URL: http://llvm.org/viewvc/llvm-project?rev=260436&view=rev Log: No reason for these two letters to be uppercase Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified: lldb/trunk/source/Commands/CommandOb

[Lldb-commits] [lldb] r260440 - Fix copy/paste error in TestCModules.

2016-02-10 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Feb 10 15:47:36 2016 New Revision: 260440 URL: http://llvm.org/viewvc/llvm-project?rev=260440&view=rev Log: Fix copy/paste error in TestCModules. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r260445 - When importing Objective-C protocols, mark them as having external decls.

2016-02-10 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Feb 10 16:00:32 2016 New Revision: 260445 URL: http://llvm.org/viewvc/llvm-project?rev=260445&view=rev Log: When importing Objective-C protocols, mark them as having external decls. We already do this for Objective-C interfaces, but we never handled protocols because the

[Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: tberghammer, clayborg, jasonmolenda. fjricci added subscribers: lldb-commits, sas. Add an optional "reverse" option to the gdb-remote command, which causes lldb to listen on the specified [host:]port, waiting for the remote server to reverse-

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 47524. fjricci added a comment. Herald added subscribers: danalbert, tberghammer, emaste. Accidentally uploaded the wrong commit. Sorry about that http://reviews.llvm.org/D17099 Files: include/lldb/Target/Platform.h include/lldb/Target/Process.h sourc

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Looks like there's a few inconsistencies with our coding style. Can you please run clang-format on this patch? http://reviews.llvm.org/D17099 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] r260452 - Revert 260436. I pretty consistently upper-case the letter I use for the

2016-02-10 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Feb 10 16:30:20 2016 New Revision: 260452 URL: http://llvm.org/viewvc/llvm-project?rev=260452&view=rev Log: Revert 260436. I pretty consistently upper-case the letter I use for the short option as an aid to memory. Like it's w because of the W in throW. That helps me r

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 47534. fjricci added a comment. Herald added a subscriber: srhines. Apply clang-format http://reviews.llvm.org/D17099 Files: include/lldb/Target/Platform.h include/lldb/Target/Process.h source/Commands/CommandObjectProcess.cpp source/Interpreter/Com

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Francis Ricci via lldb-commits
fjricci added a comment. Perhaps I ran clang-format in the wrong configuration, but it looks like it made the function declaration style in include/lldb/Target/Platform.h a bit inconsistent. Is this the desired behavior? http://reviews.llvm.org/D17099 ___

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D17099#349136, @fjricci wrote: > Perhaps I ran clang-format in the wrong configuration, but it looks like it > made the function declaration style in include/lldb/Target/Platform.h a bit > inconsistent. Is this the desired behavior? The way

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Zachary Turner via lldb-commits
(The problem is that surrounding code was not clang-formatted) On Wed, Feb 10, 2016 at 2:53 PM Zachary Turner wrote: > zturner added a comment. > > In http://reviews.llvm.org/D17099#349136, @fjricci wrote: > > > Perhaps I ran clang-format in the wrong configuration, but it looks like > it made t

Re: [Lldb-commits] [PATCH] D17099: Add reverse-connect functionality to the gdb-remote command

2016-02-10 Thread Zachary Turner via lldb-commits
zturner added a comment. (The problem is that surrounding code was not clang-formatted) http://reviews.llvm.org/D17099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

2016-02-10 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: vharron. zturner added a subscriber: lldb-commits. Hi Vince, I'm not sure why the #if _WIN32 check is even in there to begin with, but I tested on Windows 7 and Windows 10 and in both cases the output is that of the non _WIN32 path. Were

[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Cameron via lldb-commits
cameron314 created this revision. cameron314 added a reviewer: zturner. cameron314 added a subscriber: lldb-commits. cameron314 set the repository for this revision to rL LLVM. Various fixes for Win32 interop, particularly with regard to paths; paths containing non-ASCII characters now work prope

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Adrian McCarthy via lldb-commits
amccarth added a subscriber: amccarth. amccarth added a comment. I like that you're doing this, but ... There's a ton of duplication here. I'd really like to see the conversions centralized with consistent error handling. Cluttering up already-too-long functions with more #ifdefs and a half d

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Zachary Turner via lldb-commits
zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. Overall I like the idea and I'm happy to get Unicode paths and strings working properly. I'll look at the rest in more detail later, but I have some starting comments for now. On

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. Unless something has changed since last I looked, the llvm path utilities are host specific. I didn't inspect the code where this is being used, but it is in Host/common, so unless there's an ifdef WINDOWS around it, I don't think yo

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Jim Ingham via lldb-commits
Unless something has changed since last I looked, the llvm path utilities are host specific. I didn't inspect the code where this is being used, but it is in Host/common, so unless there's an ifdef WINDOWS around it, I don't think you should use the llvm path utilities. Jim > On Feb 10, 2016,

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D17107#349421, @jingham wrote: > Unless something has changed since last I looked, the llvm path utilities are > host specific. I didn't inspect the code where this is being used, but it is > in Host/common, so unless there's an ifdef WINDOWS

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Jim Ingham via lldb-commits
My bad, that sees to be what it does. Jim > On Feb 10, 2016, at 4:59 PM, Zachary Turner wrote: > > zturner added a comment. > > In http://reviews.llvm.org/D17107#349421, @jingham wrote: > >> Unless something has changed since last I looked, the llvm path utilities >> are host specific. I di

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Jim Ingham via lldb-commits
jingham added a comment. My bad, that sees to be what it does. Jim Repository: rL LLVM http://reviews.llvm.org/D17107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Cameron via lldb-commits
cameron314 added a comment. Thanks for all the feedback! I'll look into it in detail tomorrow. Perhaps it would make more sense if I clarified where I'm coming from with this patch -- we use LLDB on Windows (with a custom backend) where I work, and wanted to be able to run a program with a non-

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

2016-02-10 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D17107#349463, @cameron314 wrote: > Thanks for all the feedback! I'll look into it in detail tomorrow. > > Perhaps it would make more sense if I clarified where I'm coming from with > this patch -- we use LLDB on Windows (with a custom backend)