zturner created this revision.
zturner added a reviewer: vharron.
zturner added a subscriber: lldb-commits.
Hi Vince,
I'm not sure why the #if _WIN32 check is even in there to begin with, but I
tested on Windows 7 and Windows 10 and in both cases the output is that of the
non _WIN32 path. Were you seeing this other value in practice?
In any case, this patch fixes it for me, so I'm curious to see how this came
about.
http://reviews.llvm.org/D17106
Files:
unittests/Host/SocketAddressTest.cpp
Index: unittests/Host/SocketAddressTest.cpp
===================================================================
--- unittests/Host/SocketAddressTest.cpp
+++ unittests/Host/SocketAddressTest.cpp
@@ -33,11 +33,7 @@
ASSERT_EQ (0, sa.GetPort ());
ASSERT_TRUE (sa.SetToLocalhost (AF_INET6, 1139));
-#ifdef _WIN32
- ASSERT_STREQ ("0:0:0:0:0:0:0:1", sa.GetIPAddress ().c_str ());
-#else
ASSERT_STREQ ("::1", sa.GetIPAddress ().c_str ());
-#endif
ASSERT_EQ (1139, sa.GetPort ());
}
Index: unittests/Host/SocketAddressTest.cpp
===================================================================
--- unittests/Host/SocketAddressTest.cpp
+++ unittests/Host/SocketAddressTest.cpp
@@ -33,11 +33,7 @@
ASSERT_EQ (0, sa.GetPort ());
ASSERT_TRUE (sa.SetToLocalhost (AF_INET6, 1139));
-#ifdef _WIN32
- ASSERT_STREQ ("0:0:0:0:0:0:0:1", sa.GetIPAddress ().c_str ());
-#else
ASSERT_STREQ ("::1", sa.GetIPAddress ().c_str ());
-#endif
ASSERT_EQ (1139, sa.GetPort ());
}
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
