Author: ewancrawford
Date: Wed Oct 21 03:50:42 2015
New Revision: 250886
URL: http://llvm.org/viewvc/llvm-project?rev=250886&view=rev
Log:
[RenderScript] New commands to save/load RS allocations to file.
Patch adds command 'language renderscript allocation save' to store the
contents of an alloc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250886: [RenderScript] New commands to save/load RS
allocations to file. (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D13903?vs=37889&id=37972#toc
Repository:
rL LLVM
labath accepted this revision.
labath added a comment.
looks good, thanks.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:151
@@ +150,3 @@
+char message[PATH_MAX];
+snprintf (message, sizeof (message), "forward:tcp:%d;localfilesystem:%s",
local_port, remote_s
tberghammer accepted this revision.
Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:39
@@ +38,3 @@
+#include
+#include
+
Please don't include here if it isn't absolutely necessary as there is
a bug on windows in the header.
If you n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250890: [DataFormatters] Make libc++ list loop detection
linear (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13902?vs=37891&id=37981#toc
Repository:
rL LLVM
http://reviews
Author: labath
Date: Wed Oct 21 05:17:21 2015
New Revision: 250890
URL: http://llvm.org/viewvc/llvm-project?rev=250890&view=rev
Log:
[DataFormatters] Make libc++ list loop detection linear
Summary:
Loop detection code is being called before every element access. Although it
tries to cache some
o
labath added a subscriber: labath.
labath added a comment.
Hi,
you seem to have an out-of-bounds access here:
/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1629:5:
warning: array index 3 is past the end of the array (which contains 3
elements) [-Wa
Author: ewancrawford
Date: Wed Oct 21 05:27:10 2015
New Revision: 250891
URL: http://llvm.org/viewvc/llvm-project?rev=250891&view=rev
Log:
[RenderScript] Fix out of bounds warning.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
EwanCrawford added a comment.
Thanks for spotting, comitted a quick fix
Repository:
rL LLVM
http://reviews.llvm.org/D13903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Wed Oct 21 07:56:37 2015
New Revision: 250896
URL: http://llvm.org/viewvc/llvm-project?rev=250896&view=rev
Log:
Clean up more .dwo files after the tests run
Modified:
lldb/trunk/test/lang/cpp/incomplete-types/Makefile
lldb/trunk/test/make/Makefile.rules
lldb/trunk
brucem added a comment.
I think this looks good to me if no one disagrees.
Repository:
rL LLVM
http://reviews.llvm.org/D13715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix race conditions in Core/Timer
The Timer class already had some support for multi-threaded access
but it still contained several race conditions. This CL fixes them
i
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix some race condition in ConstString around Mangled name handling
http://reviews.llvm.org/D13941
Files:
source/Core/ConstString.cpp
Index: source/Core/ConstString.
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Make SymbolFileDWARF::GetCachedSectionData thread safe
http://reviews.llvm.org/D13942
Files:
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
source/Plugins/Symb
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Author: amccarth
Date: Wed Oct 21 09:42:10 2015
New Revision: 250899
URL: http://llvm.org/viewvc/llvm-project?rev=250899&view=rev
Log:
Skip TestMultithreaded on Windows.
Differential Revision: http://reviews.llvm.org/D13923
Modified:
lldb/trunk/test/api/multithreaded/TestMultithreaded.py
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250899: Skip TestMultithreaded on Windows. (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D13923?vs=37953&id=38012#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13923
F
evgeny777 created this revision.
evgeny777 added reviewers: ki.stfu, abidh.
evgeny777 added subscribers: lldb-commits, KLapshin.
Suppose we have the following type
```
struct S {
union {
inti1;
unsigned u1;
};
union {
inti2;
unsigned u2
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a subscriber: lldb-commits.
This short-circuits the GetObjCVersion function to avoid iterating through
target modules on
non-apple targets. This function is called on every Process::IsDynamicValue
call, so this
tberghammer updated this revision to Diff 38019.
tberghammer added a comment.
Use std::call_once instead of a std::atomic+std::mutex combination based on
some offline discussion with Pavel
http://reviews.llvm.org/D13942
Files:
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
source/Plug
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Might want to make "h" const in places noted by inlined comments,
but other than that it looks good.
Comment at: source/Core/ConstString.cpp:39
@@ -38,2 +38,3
Hi, Zachary!
On Tue, Oct 20, 2015 at 8:25 PM, Zachary Turner wrote:
> You can probably put this CL back in, just make sure you #include the
> appropriate file from LLVM in the header file.
Actually I only changed order of headers and forward declarations.
Unfortunately I don't have access to MS
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
"thread_local" isn't well supported and has performance issues. See inlined
comments.
Comment at: include/lldb/Core/Timer.h:89
@@ +88,3 @@
+
+static thread_
zturner added a subscriber: zturner.
Comment at: include/lldb/Core/Timer.h:89
@@ +88,3 @@
+
+static thread_local unsigned g_depth;
+
clayborg wrote:
> Not sure if all platforms support thread_local correctly. MacOSX might not. I
> also spoke with some compile
Author: spyffe
Date: Wed Oct 21 12:43:18 2015
New Revision: 250913
URL: http://llvm.org/viewvc/llvm-project?rev=250913&view=rev
Log:
Made the REPL choose a default language if only one REPL can be chosen.
This requires REPLs to enumerate the languages they support.
Modified:
lldb/trunk/includ
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
This is really the fault of AppleObjCRuntimeV1::CreateInstance() and
AppleObjCRuntimeV2::CreateInstance() not checking the triple to begin with, but
this is a simple solution that will eff
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13942
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
Yes, please use any llvm system utilities when possible. And scratch the need
for LLDB_THREAD_LOCAL at any point in the future and just use llvm::ThreadLocal
all the time as thread local variables have already been abstracted by llvm.
http://reviews.llvm.org/D13940
Author: zturner
Date: Wed Oct 21 12:48:52 2015
New Revision: 250915
URL: http://llvm.org/viewvc/llvm-project?rev=250915&view=rev
Log:
Use six to portably handle module renames in Python 2 and 3
Modified:
lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
lldb/trunk/test/
zturner added a comment.
Sad as it may seem, I actually think we may *need* this `LLDB_THREAD_LOCAL` at
some point in the future. The reason is that there is at least one place in
LLDB (I think it might even be in `Timer`, but it's been a while since I found
this) that relies on thread local d
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
This breaks the build because of two things:
1. The function GetLanguagesSupportingREPLs is declared static in
Language.cpp, but Language.h has it declared as a static method.
2. There is a declaration for a static method
GetREPLEnumerateSupportedLanguagesCallbackAtIndex in PluginManager,
but no d
Author: eugenezelenko
Date: Wed Oct 21 13:46:17 2015
New Revision: 250925
URL: http://llvm.org/viewvc/llvm-project?rev=250925&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13951
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250925: Fix Clang-tidy modernize-use-override warnings in
some files in… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13951?vs=38031&id=38032#toc
Repository:
rL LLVM
sivachandra created this revision.
sivachandra added a reviewer: spyffe.
sivachandra added a subscriber: lldb-commits.
This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487.
http://reviews.llvm.org/D13952
Files:
include/lldb/Core/PluginManager.h
include/lldb/Target/Language.h
includ
Author: sivachandra
Date: Wed Oct 21 13:58:01 2015
New Revision: 250927
URL: http://llvm.org/viewvc/llvm-project?rev=250927&view=rev
Log:
Revert "Made the REPL choose a default language if only one REPL can be chosen."
Summary: This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487.
Review
sivachandra added a comment.
I am going to put this in to fix the build.
http://reviews.llvm.org/D13952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250927: Revert "Made the REPL choose a default language if
only one REPL can be chosen." (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13952?vs=38033&id=38034#toc
Reposit
Yeah, this was a really lousy commit. I’m sorry I committed without checking
whether it linked. Thanks for reverting.
I will fix this and re-commit.
Sean
> On Oct 21, 2015, at 11:43 AM, Siva Chandra wrote:
>
> This breaks the build because of two things:
>
> 1. The function GetLanguagesSupp
Author: spyffe
Date: Wed Oct 21 14:14:33 2015
New Revision: 250928
URL: http://llvm.org/viewvc/llvm-project?rev=250928&view=rev
Log:
Fixed version of r250913, which actually implements all the static functions.
Thanks to Siva Chandra and Oleksiy Vyalov for pouncing on this.
Modified:
lldb/tru
Author: sivachandra
Date: Wed Oct 21 14:28:08 2015
New Revision: 250930
URL: http://llvm.org/viewvc/llvm-project?rev=250930&view=rev
Log:
[SBValue] Add a method GetNumChildren(uint32_t max)
Summary:
Along with this, support for an optional argument to the "num_children"
method of a Python synthet
Author: spyffe
Date: Wed Oct 21 14:31:17 2015
New Revision: 250931
URL: http://llvm.org/viewvc/llvm-project?rev=250931&view=rev
Log:
Fix error handling when there are no REPLs installed.
Before, in the absence of any configured REPLs, LLDB would act as if there were
multiple possible REPL options,
Author: ovyalov
Date: Wed Oct 21 14:34:26 2015
New Revision: 250933
URL: http://llvm.org/viewvc/llvm-project?rev=250933&view=rev
Log:
Add domain socket support to gdb-remote protocol and lldb-server.
http://reviews.llvm.org/D13881
Added:
lldb/trunk/tools/lldb-server/Acceptor.cpp
lldb/tr
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/lldb.xcodeproj/project.pbxproj
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lld
Author: eugenezelenko
Date: Wed Oct 21 15:03:58 2015
New Revision: 250937
URL: http://llvm.org/viewvc/llvm-project?rev=250937&view=rev
Log:
Revert r250925 in source/Plugins/OperatingSystem/Go to fix MSVC builds failures.
Modified:
lldb/trunk/source/Plugins/OperatingSystem/Go/OperatingSystemGo
On Tue, Oct 20, 2015 at 7:40 PM Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> jingham added a comment.
>
> The generic parts of this change look fine to me, with a few inlined style
> comments.
>
> I didn't read the Go specific parts of this in detail, I assume you're
> going
Author: gclayton
Date: Wed Oct 21 16:55:16 2015
New Revision: 250952
URL: http://llvm.org/viewvc/llvm-project?rev=250952&view=rev
Log:
Fix typo so that "./dotest.py --results-formatter=curses_results.Curses
--results-file=/dev/stdout" works again.
Modified:
lldb/trunk/test/lldbcurses.py
Mo
Author: ovyalov
Date: Wed Oct 21 16:58:22 2015
New Revision: 250953
URL: http://llvm.org/viewvc/llvm-project?rev=250953&view=rev
Log:
Fix lldb-server - write null terminating symbol along with port number.
Modified:
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
Modified: lldb/trunk/tools/
krytarowski added a comment.
This ncurses header is now the blocker for buildslave.
[2817/3214] Building CXX object
tools/lldb/source/Core/CMakeFiles/lldbCore.dir/IOHandler.cpp.o
FAILED: /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_
tfiala created this revision.
tfiala added a reviewer: granata.enrico.
tfiala added a subscriber: lldb-commits.
This change fixes data formatters for libstdc++ 6.0.21:
* Adds std::string data formatter support in C++ (rather than Python) for
6.0.21+.
* Uses std::list count field support when pre
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Looks good to me
http://reviews.llvm.org/D13964
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
First, sorry for my delay in reviewing your patch, but I've been on vacation
and now am at the C++ ANSI meeting in Kona for this week. But...
This broke the build of cmake on OSX. We get:
[...]
[2
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: tfiala
Date: Wed Oct 21 19:23:38 2015
New Revision: 250965
URL: http://llvm.org/viewvc/llvm-project?rev=250965&view=rev
Log:
Fix libstdc++ data formatters on Ubuntu 15.10 x86_64
See http://reviews.llvm.org/D13964 for details.
Modified:
lldb/trunk/examples/synthetic/gnu_libstdcpp.py
Author: eugenezelenko
Date: Wed Oct 21 19:45:41 2015
New Revision: 250966
URL: http://llvm.org/viewvc/llvm-project?rev=250966&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in
source/Plugins/LanguageRuntime; other minor fixes.
Differential Revision: http://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250966: Fix Clang-tidy modernize-use-override warnings in
some files in… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13966?vs=38065&id=38067#toc
Repository:
rL LLVM
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Looks like MSVC build failure didn't relate to my changes, since I didn't
remove lldb/Ex
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
lgtm. In the future you don't need to ask for a review to unbreak a build.
Repository:
rL LLVM
http://reviews.llvm.org/D13968
___
lldb-comm
brucem added a subscriber: brucem.
brucem added a comment.
You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.)
I think the minimum supported cmake is actually older then 3.0 (2.8.something)
...
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
cmake_minimum_required(VERSION 2.8)
in CMakeLists.txt
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@li
enlight added a subscriber: enlight.
enlight added a comment.
I believe LLVM requires CMake 2.8.12 or later (at least that was the case
when I looked three weeks ago).
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb
Author: jmolenda
Date: Wed Oct 21 22:44:51 2015
New Revision: 250978
URL: http://llvm.org/viewvc/llvm-project?rev=250978&view=rev
Log:
Add some verbose lldb host logging so lldb will show what SDK
directories it is searching for files.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/Platf
Author: jmolenda
Date: Wed Oct 21 22:50:28 2015
New Revision: 250979
URL: http://llvm.org/viewvc/llvm-project?rev=250979&view=rev
Log:
Change ModuleList::GetSharedModule so that it will reject "stub
libraries" altogether. On Mac/iOS, these are libraries which have
a UUID and nlist records but no
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath.
ovyalov added a subscriber: lldb-commits.
Abstract domain sockets are supported only by Linux (at least, as documentation
says) so I'm putting new socket class into linux subfolder.
Since there is a possibility that abstrac
Author: jmolenda
Date: Wed Oct 21 23:17:26 2015
New Revision: 250981
URL: http://llvm.org/viewvc/llvm-project?rev=250981&view=rev
Log:
Move the launch-as-root xpc service from lldb to xcode, to
make it easier to run hand-built lldb roots and retain those
entitlements. This is currently only used
66 matches
Mail list logo
