[Lldb-commits] [lldb] r250801 - [LLDB] Insert names with same signo as alias instead of a new entry

Author: mohit.bhakkad Date: Tue Oct 20 02:05:46 2015 New Revision: 250801 URL: http://llvm.org/viewvc/llvm-project?rev=250801&view=rev Log: [LLDB] Insert names with same signo as alias instead of a new entry Reviewers: clayborg, labath. Subscribers: jaydeep, dsanders, bhushan, sagar, nitesh.jain,

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

This revision was automatically updated to reflect the committed changes. Closed by commit rL250801: [LLDB] Insert names with same signo as alias instead of a new entry (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13646?vs=37469&id=37828#toc Repository: rL L

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

mohit.bhakkad added a comment. In http://reviews.llvm.org/D13646#267953, @labath wrote: > This looks much better, I just have a couple of small remarks. @labath addressed these while committing. Repository: rL LLVM http://reviews.llvm.org/D13646 _

[Lldb-commits] [lldb] r250810 - Fix build and some warnings after r250798

Author: tberghammer Date: Tue Oct 20 04:21:04 2015 New Revision: 250810 URL: http://llvm.org/viewvc/llvm-project?rev=250810&view=rev Log: Fix build and some warnings after r250798 Modified: lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h lldb/trunk/include/lldb/DataFormatters/

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

labath added a comment. I *think* it looks good, but I find it quite hard to review a change of this size. A wise man once said "if your commit description contains bullet points, you are doing too much". I think it would be better to split up changes like this in the future. > Make PlatformRe

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

mohit.bhakkad updated this revision to Diff 37843. mohit.bhakkad added a comment. This patch makes server send an End of register(E45) response if a register present in reginfo is not available on actual machine. Repository: rL LLVM http://reviews.llvm.org/D13859 Files: source/Plugins/Pr

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

tberghammer added a comment. Looks good with a few minor comments inline One additional design question: What is your opinion about specifying the default value for the memory cache line size (the 512 byte) in Platform::GetDefaultMemoryCacheLineSize() instead of in the property definition? I th

[Lldb-commits] [lldb] r250814 - Increase default memory cache line size for android

Author: labath Date: Tue Oct 20 05:33:17 2015 New Revision: 250814 URL: http://llvm.org/viewvc/llvm-project?rev=250814&view=rev Log: Increase default memory cache line size for android Summary: ADB packets have a maximum size of 4k. This means the size of memory reads does not affect speed too m

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath added a comment. Good catch. fixed and committed. Repository: rL LLVM http://reviews.llvm.org/D13812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

This revision was automatically updated to reflect the committed changes. Closed by commit rL250814: Increase default memory cache line size for android (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13812?vs=37776&id=37845#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

labath added a comment. I believe adding this to qHostInfo is over-engineering at the moment. But it's a good idea, and we can do it if we have a need for more control of this in the future. Repository: rL LLVM http://reviews.llvm.org/D13812 __

Re: [Lldb-commits] [PATCH] D12890: Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader breakpoint optional.

loladiro added a subscriber: loladiro. loladiro added a comment. @clayborg Given that this was merged, does it make sense to now allow the JITLoader to be created on OS X as well, but set the setting to false by default? Does that address the performance concern you had initially? http://revie

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

labath added a comment. I think this should go in a little bit deeper, i.e., inside the NativeRegisterContextLinux_mips, or whatever is the right class for you. I think this is better for several reasons: - if the register is physically not present, the register context should not report it (t

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

labath added a comment. > When such an error occurs, it is unlikely to be an lldb bug, or > data-formatter bug. One can come up with a data structure for which reading a > child element would require complete debug info, but reading the # of child > elements need not require complete debug info

[Lldb-commits] [lldb] r250820 - Add a new task pool class to LLDB

Author: tberghammer Date: Tue Oct 20 07:42:05 2015 New Revision: 250820 URL: http://llvm.org/viewvc/llvm-project?rev=250820&view=rev Log: Add a new task pool class to LLDB The purpose of the class is to make it easy to execute tasks in parallel Basic design goals: * Have a very lightweight and e

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

This revision was automatically updated to reflect the committed changes. Closed by commit rL250821: Make dwarf parsing multi-threaded (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13662?vs=37353&id=37866#toc Repository: rL LLVM http://reviews.llvm.org/D13662

[Lldb-commits] [lldb] r250821 - Make dwarf parsing multi-threaded

Author: tberghammer Date: Tue Oct 20 07:42:10 2015 New Revision: 250821 URL: http://llvm.org/viewvc/llvm-project?rev=250821&view=rev Log: Make dwarf parsing multi-threaded Loading the debug info from a large application is the slowest task LLDB do. This CL makes most of the dwarf parsing code mul

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

This revision was automatically updated to reflect the committed changes. tberghammer marked 4 inline comments as done. Closed by commit rL250820: Add a new task pool class to LLDB (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13727?vs=37566&id=37865#toc Reposito

[Lldb-commits] [lldb] r250832 - Revert "Make dwarf parsing multi-threaded"

Author: tberghammer Date: Tue Oct 20 10:43:40 2015 New Revision: 250832 URL: http://llvm.org/viewvc/llvm-project?rev=250832&view=rev Log: Revert "Make dwarf parsing multi-threaded" Revert it bacuse it introduces several race condition detected by the build bots. This reverts commit 5107a5ebdb7c4

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

zturner added a comment. Greg, Enrico, anyone have a chance to take a look at this? I think it's probably just a rubber stamp but rather err on the side of caution. http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.ll

Re: [Lldb-commits] [lldb] r250832 - Revert "Make dwarf parsing multi-threaded"

This is kind of why I pushed back against this in the first place :-/ It's hard to get right. I still wish we could find a way to use standard library facilities for this, either by splitting the compile units into hardware_concurrency chunks, or kicking off no more than hardware_concurrency comp

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

evgeny777 updated this revision to Diff 37888. evgeny777 added a comment. Update according to suggestions from granata.enrico http://reviews.llvm.org/D13799 Files: test/tools/lldb-mi/data/TestMiData.py test/tools/lldb-mi/symbol/TestMiSymbol.py tools/lldb-mi/MICmnLLDBDebugger.cpp tools/l

[Lldb-commits] [lldb] r250833 - Fix MSVC build after 250820

Author: tberghammer Date: Tue Oct 20 11:16:35 2015 New Revision: 250833 URL: http://llvm.org/viewvc/llvm-project?rev=250833&view=rev Log: Fix MSVC build after 250820 Work around a bug in MSVC 12 where _HAS_EXCEPTIONS=0 don't eliminate all usage of __uncaught_exception with including eh.h what dec

Re: [Lldb-commits] [lldb] r250832 - Revert "Make dwarf parsing multi-threaded"

The race condition made me to revert this change is inside the dwarf parsing code (and in some other part of LLDB), not in the thread pool implementation. I run the unit-tests I wrote under TSAN and they all run cleanly so I don't really expect any race condition coming from that part of the code.

[Lldb-commits] [PATCH] D13902: [DataFormatters] Make libc++ list loop detection linear

labath created this revision. labath added a reviewer: granata.enrico. labath added subscribers: sivachandra, lldb-commits. Loop detection code is being called before every element access. Although it tries to cache some of the data by remembering the loop-free initial segment, every time it need

[Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus. EwanCrawford set the repository for this revision to rL LLVM. Patch adds command 'language renderscript allocation save' to store the contents of an alloca

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Minor nit over ordering of #include, but other than that it looks good. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:36 @@ -31,1

Re: [Lldb-commits] [PATCH] D12890: Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader breakpoint optional.

clayborg added a comment. So you are saying to have a setting that allows this plug-in to be enabled and have it set to false by default? That sounds good to me. It probably should be false on all platforms and anyone wanting JIT support should enable it? http://reviews.llvm.org/D12890

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Is there a list of error codes and what they mean for the GDB remote protocol? debugserver returns random errors and doesn't abide by any specific error codes. Quote from some GD

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2087-2088 @@ +2086,4 @@ +results.emplace_back(TaskPool::AddTask(parser_fn, cu_idx)); +for (auto& f : results) +f.wait(); + S

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good to me. Wait for Enrico to OK as well. http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. Apart from some inline comments, looks ok to me. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:839 @@ +838,3 @@ +// Return: MIstatus::success - Functionality succeeded. +//

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Going forward there is no real need to review any new commands that only exist in the renderscript source files or plug-ins. If you change any code outside of the the renderscr

Re: [Lldb-commits] [PATCH] D13902: [DataFormatters] Make libc++ list loop detection linear

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. That looks reasonable. Of course, I assume you ran the test suite on OS X, including your new evil test! http://reviews.llvm.org/D13902

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

tberghammer added a comment. I reverted this change, as it caused some race condition, but see my comment inline. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2087-2088 @@ +2086,4 @@ +results.emplace_back(TaskPool::AddTask(parser_fn, c

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

granata.enrico accepted this revision. granata.enrico added a comment. Looks reasonable http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13906: Introduce a mechanism for sharing code across lldb/test and lldb/scripts

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. We have a lot of Python code in test and scripts that in theory could be reused amongst the two. Until now there is no mechanism to support this because Python's module / packaging system

[Lldb-commits] [lldb] r250838 - Fix potential file i/o problem with python handles.

Author: zturner Date: Tue Oct 20 12:38:49 2015 New Revision: 250838 URL: http://llvm.org/viewvc/llvm-project?rev=250838&view=rev Log: Fix potential file i/o problem with python handles. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/trunk/source/Pl

Re: [Lldb-commits] [lldb] r248028 - Make libc++ tests skip themselves if libc++ is not actually loaded in the target

Hi Enrico, Could you explain what was the motivation behind this change? I am asking because, I have just learned that this commit has caused all libc++ tests to be skipped on linux*, silently decreasing test coverage on linux. I would like to replace this with some other mechanism, which is not

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + Eugene.Zelenko wrote: > Please add include section comments. Same for other sections. Which sections? I've seen a couple types of section mar

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

Eugene.Zelenko added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + ribrdb wrote: > Eugene.Zelenko wrote: > > Please add include section comments. Same for other sections. > Which sections? I've seen a

Re: [Lldb-commits] [lldb] r248028 - Make libc++ tests skip themselves if libc++ is not actually loaded in the target

> On Oct 20, 2015, at 10:43 AM, Pavel Labath wrote: > > Hi Enrico, > > Could you explain what was the motivation behind this change? > As per title of the commit, in a process that is using a standard c++ library other than libc++, these tests are noise - of course the libc++ tests aren’t g

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. See inlined comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2087-2088 @@ +2086,4 @@ +results.emplace_back(TaskPool::AddTask(parser_fn, cu_idx)); +for (auto& f : results) +f.wait(); +

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb updated this revision to Diff 37898. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj source/API/SystemInitializerFull.cpp source/Plugins/Language/CMakeLists.txt source/Plugins/Language/Go/CMakeLists.txt so

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

Eugene.Zelenko added a comment. Did you format code with Clang-format? Spaces/no spaces between function names and arguments are inconsistent. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:29 @@ +28,3 @@ + +#include "clang/AST/ASTContext.h" + Th

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb removed rL LLVM as the repository for this revision. ribrdb updated this revision to Diff 37900. ribrdb added a comment. Oops, I ran clang-format with the wrong arguments. Ran it again. http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] New llvm build server account request

Hello Kamil, It looks like you are missing dependencies for the LLDB builder you have chosen. http://lab.llvm.org:8014/builders/lldb-amd64-ninja-netbsd7/builds/75/steps/update%20scripts/logs/stdio The getLLDBScriptCommandsFactory build factory does not document the assumed dependency, so you may

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

zturner added a comment. Greg, do you have any concerns here? http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. So before getting into the details of the patch, there's a structural bit it would be nice to fix. When I was separating out bits of the Expression machinery, I assumed that even

[Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. This uses the `six.add_metaclass()` decorator for portable metaclass specification. http://reviews.llvm.org/D13912 Files: test/dotest.py test/lldbtest.py Index: test/lldbtest.py =

Re: [Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

zturner added a comment. Thanks. This is still blocked on my 2 earlier CLs (one adding six to the repo, and the other hooking up six to be recognized by dotest). If you get a chance can you take a look at those? http://reviews.llvm.org/D13912 __

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

tfiala added a comment. In http://reviews.llvm.org/D13880#270742, @zturner wrote: > Todd, do you have any good ideas on how to organize this and make it play > nicely with python's module / package system? `dotest` is just an arbitrary > script under lldb/test and is not part of any installed

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello Ying, I'm in trouble with my attempts to connect my NetBSD/amd64 machine to the LLDB/LLVM build zone. My host is NetBSD-7.0 (with buildslave ID: lldb-amd64-ninja-netbsd7). I use pkgsrc (2015Q3) to ship packages. I'm attaching a list of instal

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

tfiala added a comment. In http://reviews.llvm.org/D13880#271483, @tfiala wrote: > In http://reviews.llvm.org/D13880#270742, @zturner wrote: > > > Todd, do you have any good ideas on how to organize this and make it play > > nicely with python's module / package system? `dotest` is just an > >

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. All that aside, LGTM. http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

zturner added a comment. Yea, I actually did something very similar to that. Check out http://reviews.llvm.org/D13906 http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13906: Introduce a mechanism for sharing code across lldb/test and lldb/scripts

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Yep, like it. http://reviews.llvm.org/D13906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

tfiala added a comment. In http://reviews.llvm.org/D13912#271481, @zturner wrote: > Thanks. This is still blocked on my 2 earlier CLs (one adding six to the > repo, and the other hooking up six to be recognized by dotest). If you get a > chance can you take a look at those? Yep, I didn't re

Re: [Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

zturner added a comment. Thanks! http://reviews.llvm.org/D13912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250859 - Use six to portably assign metaclasses in Python 2 and 3.

Author: zturner Date: Tue Oct 20 16:06:05 2015 New Revision: 250859 URL: http://llvm.org/viewvc/llvm-project?rev=250859&view=rev Log: Use six to portably assign metaclasses in Python 2 and 3. Modified: lldb/trunk/test/dotest.py lldb/trunk/test/lldbtest.py Modified: lldb/trunk/test/dotest

[Lldb-commits] [lldb] r250857 - Add `six` Python module to lldb/third_party.

Author: zturner Date: Tue Oct 20 16:05:49 2015 New Revision: 250857 URL: http://llvm.org/viewvc/llvm-project?rev=250857&view=rev Log: Add `six` Python module to lldb/third_party. Six is a python module designed to smooth the process of porting Python 2 code to Python 3. Specifically, six provide

[Lldb-commits] [lldb] r250858 - Introduce a mechanism for reusing Python modules out of tree.

Author: zturner Date: Tue Oct 20 16:05:57 2015 New Revision: 250858 URL: http://llvm.org/viewvc/llvm-project?rev=250858&view=rev Log: Introduce a mechanism for reusing Python modules out of tree. Right now our Python code does not all share a common root. Tests and scripts both contain python co

[Lldb-commits] [PATCH] D13916: D13840 [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Repository: rL LLVM http://reviews.ll

Re: [Lldb-commits] [PATCH] D13912: Make uses of metaclasses portable across Python versions

tfiala added a comment. Sure thing! http://reviews.llvm.org/D13912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

ovyalov updated this revision to Diff 37928. ovyalov added a comment. - Renamed LaunchGDBserverAndGetPort into LaunchGDBServer within PlatformAndroidRemoteGDBServer/PlatformRemoteGDBServer/GDBRemoteCommunicationClient - Fixed includes' order. - Added Acceptor::LocalSocketId which returns either T

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

sivachandra updated this revision to Diff 37937. sivachandra added a comment. Add tests. http://reviews.llvm.org/D13778 Files: include/lldb/API/SBValue.h include/lldb/Core/ValueObject.h include/lldb/Core/ValueObjectCast.h include/lldb/Core/ValueObjectChild.h include/lldb/Core/ValueObj

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

ovyalov added a comment. In http://reviews.llvm.org/D13881#270878, @labath wrote: > I *think* it looks good, but I find it quite hard to review a change of this > size. > A wise man once said "if your commit description contains bullet points, you > are doing too much". I think it would be bet

Re: [Lldb-commits] New llvm build server account request

Hello Kamil, Galina, If you would like to build LLDB with cmake and ninja, I suggest to consider the following two factory functions. Depends on what you described, I feel the first one works better for you. 1. getLLDBUbuntuCMakeBuildFactory If you only run local lldb tests, this is the factory t

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Where can I find this updateScripts.sh? It's missing under your link: https://android.googlesource.com/platform/external/lldb-utils/+/lldb-mas ter-dev/buildbotScripts/bashShell/svntotbuild/ On 21.10.2015 00:29, Ying Chen wrote: > Hello Kamil, Galin

Re: [Lldb-commits] New llvm build server account request

Please check again. Please note that this file needs to be included in your PATH. The rest of the scripts don't have to. Sample of test configuration file could be found here. https://android.googlesource.com/platform/external/lldb-utils/+/lldb-master-dev/buildbotScripts/testCfg/ On Tue, Oct 20, 2

[Lldb-commits] [PATCH] D13921: Use six to portably handle module renames

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. http://reviews.llvm.org/D13921 Files: test/api/check_public_api_headers/TestPublicAPIHeaders.py test/api/multiple-debuggers/TestMultipleDebuggers.py test/api/multithreaded/TestMultithr

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 It just appeared there. I took your updateScripts.sh, moved it to my $PATH. Is it everything? Will the rest of the scripts from https://android.googlesource.com/platform/external/lldb-utils/+/lldb-mas ter-dev/buildbotScripts/bashShell/svntotbuild/

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

clayborg accepted this revision. clayborg added a comment. Accepted as long as Enrico is OK with this. http://reviews.llvm.org/D13778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Looks fine http://reviews.llvm.org/D13778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [Lldb-commits] New llvm build server account request

On Tue, Oct 20, 2015 at 4:46 PM, Kamil Rytarowski wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > It just appeared there. > > I took your updateScripts.sh, moved it to my $PATH. Is it everything? Please also put the test_cfg.json to this location, /home/motus/build/build/. A dumm

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 21.10.2015 02:03, Ying Chen wrote: > > > On Tue, Oct 20, 2015 at 4:46 PM, Kamil Rytarowski > wrote: > > It just appeared there. > > I took your updateScripts.sh, moved it to my $PATH. Is it > everything? > > >> Please a

[Lldb-commits] [lldb] r250869 - When target is NULL, provide a debugger so that REPLs can use that to create

Author: spyffe Date: Tue Oct 20 19:28:44 2015 New Revision: 250869 URL: http://llvm.org/viewvc/llvm-project?rev=250869&view=rev Log: When target is NULL, provide a debugger so that REPLs can use that to create their own target. Modified: lldb/trunk/include/lldb/Expression/REPL.h lldb/trun

[Lldb-commits] [lldb] r250870 - When a REPL creates a new target for itself, it is that target's REPL.

Author: spyffe Date: Tue Oct 20 19:36:34 2015 New Revision: 250870 URL: http://llvm.org/viewvc/llvm-project?rev=250870&view=rev Log: When a REPL creates a new target for itself, it is that target's REPL. To allow that, I've added a SetREPL call to the Target, which allows a REPL that just created

[Lldb-commits] [PATCH] D13923: Skip TestMultithread.py on Windows because it times out (and they'd fail anyway)

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. I'm not sure why this was timing out when running on my machine, since it took only 45 second for the tests to fail and the timeout seem to be set to 240 seconds. Simply skipping these

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 http://lab.llvm.org:8014/builders/lldb-amd64-ninja-netbsd7/builds/90 cmake.sh is still wrong: #!/bin/bash -e set -x host=$(uname) if [[ $host != Linux ]]; then echo "Skip cmake step for" $host else source setEnv.sh mkdir -p $buildDir cd $bu

[Lldb-commits] [lldb] r250872 - Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

Author: eugenezelenko Date: Tue Oct 20 20:03:30 2015 New Revision: 250872 URL: http://llvm.org/viewvc/llvm-project?rev=250872&view=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes. Differential Revision: http://reviews.llvm.org/D13916 Mo

Re: [Lldb-commits] [PATCH] D13916: [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250872: Fix Clang-tidy modernize-use-override warnings in some files in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13916?vs=37922&id=37956#toc Repository: rL LLVM

Re: [Lldb-commits] New llvm build server account request

Submitted the change, http://reviews.llvm.org/rL250871 The problem you mentioned has been resolved. But clang is missing from your system. You need to make sure the system is able to build and test lldb. Follow this http://lldb.llvm.org/build.html#BuildingLldbOnLinux. On Tue, Oct 20, 2015 at 5:4

Re: [Lldb-commits] [PATCH] D13921: Use six to portably handle module renames

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 My $CC/$CXX is GCC 4.8.5. I have good reason for it - to not intermix system-wide and fetched headers for llvm. In the past this was causing problems for me during my lldb porting. Please update my builder.py for using gcc. On 21.10.2015 03:11, Yi

[Lldb-commits] [lldb] r250874 - Revert r250872 in source/Plugins/Disassembler to fix MSVC builds failures.

Author: eugenezelenko Date: Tue Oct 20 20:42:15 2015 New Revision: 250874 URL: http://llvm.org/viewvc/llvm-project?rev=250874&view=rev Log: Revert r250872 in source/Plugins/Disassembler to fix MSVC builds failures. Modified: lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp

Re: [Lldb-commits] New llvm build server account request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Please update the documentation from http://lldb.llvm.org/build.html#BuildingLldbOnLinux. and add an entry for NetBSD: On NetBSD one might run: > pkgin install swig python27 Regarding the cmake issue, I suggest to add this change to cmake.sh: if [

Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform

brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. This revision now requires changes to proceed. Comment at: lib/Makefile:146 @@ -144,1 +145,3 @@ +ifneq ($(HOST_OS),NetBSD) + USEDLIBS += lldbPluginProcessPOSIX.a -

Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform

krytarowski updated this revision to Diff 37957. krytarowski added a comment. Typos. Repository: rL LLVM http://reviews.llvm.org/D13715 Files: lib/Makefile source/Host/Makefile source/Host/netbsd/Makefile source/Plugins/Makefile source/Plugins/Platform/Makefile source/Plugins/Pla

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

jingham added a comment. The generic parts of this change look fine to me, with a few inlined style comments. I didn't read the Go specific parts of this in detail, I assume you're going to get those right. I mentioned a couple of style things inline, though I didn't mark everywhere that they

Re: [Lldb-commits] [lldb] r250874 - Revert r250872 in source/Plugins/Disassembler to fix MSVC builds failures.

You can probably put this CL back in, just make sure you #include the appropriate file from LLVM in the header file. On Tue, Oct 20, 2015 at 6:44 PM Eugene Zelenko via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: eugenezelenko > Date: Tue Oct 20 20:42:15 2015 > New Revision: 25087

Re: [Lldb-commits] [lldb] r250870 - When a REPL creates a new target for itself, it is that target's REPL.

This is a good example of where a "null repl" would be great for testing. You don't need a language to verify, for example, that when a repl creates a new target for itself, it is correcly set as the repl for that target. And even if you had a language specific repl, that wouldn't really be the rig

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

dberlin added a comment. LGTM from a license perspective. It doesn't impose any interesting obligations. http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com