labath added a comment.

I think this should go in a little bit deeper, i.e., inside the 
NativeRegisterContextLinux_mips, or whatever is the right class for you. I 
think this is better for several reasons:

- if the register is physically not present, the register context should not 
report it (through GetUserRegisterCount, GetRegisterInfoAtIndex, etc.) - 
someone else may be iterating through the registers in the context and doing 
stuff - he will get errors when encountering your registers
- this can cause us to silently lose some registers if we fail to read them for 
any reason (due to an unrelated bug somewhere)


Repository:
  rL LLVM

http://reviews.llvm.org/D13859



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to