github-actions[bot] wrote:
@kendalharland Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kendalharland wrote:
I'll need help merging this since I don't have write access to the repo.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
kendalharland wrote:
Apologies, I push the wrong commits to this PR and just had the fix them up.
Should be good to go.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From e3715f9928c6cd96a6cc96ea3cea8a8a735a7556 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 0ec149a364061432a9b7bd8d79ddbb5706b182dc Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 108865deb28016f6ebe7c507e082e0998a4d4839 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 1 Jul 2024 10:33:51 -0700
Subject: [PATCH 1/3] Fix type error when calling random.randrange with 'float'
arg
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From b880f6d7951534fd90c3728fb9cabbe515295557 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH 1/2] Fix flake in TestZerothFrame.py
This test is relying on the o
kendalharland wrote:
Applied formatter patch and rebased onto main
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From b880f6d7951534fd90c3728fb9cabbe515295557 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From a3c524bebfc976f3dfee5b67dac490ed44705d6a Mon Sep 17 00:00:00 2001
From: kendal
Date: Wed, 3 Jul 2024 11:18:43 -0700
Subject: [PATCH 1/2] Fix type error when calling random.randrange with 'float'
arg
kendalharland wrote:
Sure thing, I hadn't hooked up the formatter yet so I'll run it and reupload.
Thanks for the reviews!
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
bulbazord wrote:
Yes, looks good to me. Thanks for taking the time! :)
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > Looks good. Are you able to merge this on your own?
>
> Nope, I'll need someone with write access to do it.
Sounds good. Can you just patch the formatter changes in, and then I'll submit
it.
@bulbazord, if you don't respond, I'm going to assume that new version
addresses yo
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7c83b7ef1796210451b839f4c58f2815f4aedfe5...e3d44a2fed3d4129e245d5695c3af0c21bb7b329
lldb/
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From e3d44a2fed3d4129e245d5695c3af0c21bb7b329 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
kendalharland wrote:
> Looks good. Are you able to merge this on your own?
Nope, I'll need someone with write access to do it.
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 1d2c11e18e833104279fa6a005e4a64bb7be6216 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/labath approved this pull request.
Looks good. Are you able to merge this on your own?
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kendalharland wrote:
> This should be fine, although looking at the test case again, I think that
> even simply replacing process.GetThreadAtIndex(0) with self.thread() should
> be enough. self.thread() returns the "selected" thread and lldb should always
> be selecting the thread which has st
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 1d2c11e18e833104279fa6a005e4a64bb7be6216 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/labath approved this pull request.
This should be fine, although looking at the test case again, I think that even
simply replacing `process.GetThreadAtIndex(0)` with `self.thread()` should be
enough. `self.thread()` returns the "selected" thread and lldb should always be
se
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From abc87f3cbadc47f7f0bfaf01fcdf7f7c6d4bfeb5 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
kendalharland wrote:
> The thread that you care about is stopped at a breakpoint, right? If so, then
> you can use the lldbutil.get_threads_stopped_at_breakpoint utility to find
> it...
Thanks, this eventually led to me what I think is the most obvious solution: We
can just set the breakpoint
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 836b5ee62a5e1e31fe973e1f4ff6cd47f10eca84 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 1ca25a240cf459e16fb762f750e84260610c1077 Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
labath wrote:
The thread that you care about is stopped at a breakpoint, right?
If so, then you can use the `lldbutil.get_threads_stopped_at_breakpoint`
utility to find it...
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing lis
JDevlieghere wrote:
> Sounds reasonable. I'll work that out with a helper method and resend for
> review once I upload a new commit. @bulbazord any idea how I can access the
> module from the `SBThread` object, to compare it against the name `a.out`?
> I'm having trouble finding the right API.
kendalharland wrote:
> Instead of assuming the thread's index or index ID, it might be a good idea
> to have a little helper method that can look through the inferior's threads
> to find the thread with the property that we care about. In this case, we're
> looking for the thread that's stoppe
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
Instead of assuming the thread's index or index ID, it might be a good idea to
have a little helper method that can look through the inferior's threads to
find the thread with the property that we care about. In this case, we'
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/96685
>From 97242b723de7fd4dcb14bd8481acc2254ab852ea Mon Sep 17 00:00:00 2001
From: kendal
Date: Mon, 24 Jun 2024 13:42:20 -0700
Subject: [PATCH] Fix flake in TestZerothFrame.py
This test is relying on the order
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/96685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
This test is currently flaky on a local Windows amd64 build.
If we print lldb's inputs and outputs while running, we can see that the
breakpoints are always being set correctly, and always being hit:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/96685
This test is currently flaky on a local Windows amd64 build.
If we print lldb's inputs and outputs while running, we can see that the
breakpoints are always being set correctly, and always being hit:
```s
45 matches
Mail list logo
