https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cs01 wrote:
I think I have everything in order now, it's ready for another pass. Thank you
so much for your time and help on this!
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/cs01 ready_for_review
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
>From 4756820fa10e1c9b98616947780eb4dc83bc98e1 Mon Sep 17 00:00:00 2001
From: Chad Smith
Date: Tue, 29 Jul 2025 10:00:02 -0700
Subject: [PATCH] refactor android platform
---
.../Plugins/Platform/Android/AdbClient.
cs01 wrote:
Hi, yes sorry about that. I did not mean to push the file that state, so I
marked the PR as draft while I get it in order. Generally it's ready for a
review other than the ConnectionFileDescriptor changes if you want to give a
look with that in mind. Btw I see there are workflows w
https://github.com/labath commented:
I have a feeling something went wrong with the latest update. (I don't think
you meant to undo the last months changes to ConnectionFileDescriptor). Can you
fix that? I'm fine with a force-push, if needed.
Did you also want to drop the "Draft" annotation (m
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
Unicorn! ยท GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px auto 4
@@ -220,6 +220,12 @@ ConnectionStatus
ConnectionFileDescriptor::Disconnect(Status *error_ptr) {
// Prevents reads and writes during shutdown.
m_shutting_down = true;
+ if (!m_io_sp) {
cs01 wrote:
I will remove and possibly add in a different PR
https:/
@@ -20,212 +18,342 @@ using namespace testing;
namespace {
-class MockSyncService : public AdbClient::SyncService {
+class MockConnection : public Connection {
labath wrote:
Is this used anywhere? If it is, it may be better to just use a real connection
ins
@@ -0,0 +1,46 @@
+//===-- AdbClientUtils.h
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -220,6 +220,12 @@ ConnectionStatus
ConnectionFileDescriptor::Disconnect(Status *error_ptr) {
// Prevents reads and writes during shutdown.
m_shutting_down = true;
+ if (!m_io_sp) {
labath wrote:
Is this still needed? I mean, it sort of makes sense, b
@@ -8,98 +8,45 @@
#include "AdbClient.h"
-#include "llvm/ADT/STLExtras.h"
-#include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/FileUtilities.h"
-
-#include "lldb/Host/ConnectionFileDescriptor.h"
-#include "lldb/Host/FileSystem.h"
-#inclu
@@ -32,50 +34,14 @@ class AdbClient {
using DeviceIDList = std::list;
- class SyncService {
-friend class AdbClient;
-
- public:
-virtual ~SyncService();
-
-virtual Status PullFile(const FileSpec &remote_file,
-const FileSpec &local
@@ -418,13 +436,68 @@ bool PlatformAndroid::GetRemoteOSVersion() {
return !m_os_version.empty();
}
+uint32_t PlatformAndroid::FindProcesses(
+const ProcessInstanceInfoMatch &match_info,
+ProcessInstanceInfoList &process_infos) {
+ Status error;
+ AdbClientUP adb(Ge
@@ -418,13 +436,68 @@ bool PlatformAndroid::GetRemoteOSVersion() {
return !m_os_version.empty();
}
+uint32_t PlatformAndroid::FindProcesses(
labath wrote:
How does this relate to the rest of the patch?
https://github.com/llvm/llvm-project/pull/145382
_
@@ -445,11 +518,9 @@
PlatformAndroid::GetLibdlFunctionDeclarations(lldb_private::Process *process) {
}
PlatformAndroid::AdbClientUP PlatformAndroid::GetAdbClient(Status &error) {
- AdbClientUP adb(std::make_unique(m_device_id));
- if (adb)
-error.Clear();
- else
-e
@@ -108,62 +55,73 @@ Status AdbClient::CreateByDeviceID(const std::string
&device_id,
"Expected a single connected device, got instead %zu - try "
"setting 'ANDROID_SERIAL'",
connected_devices.size());
-adb.SetDeviceID(connected_devices.front(
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I like what you've done, though it makes it a bit difficult to review. In the
future, if you find yourself moving lot of code around, try to separate that
from the functional changes into a PR of its own. That makes things flow a lot
easier.
In this case,
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/metacpp deleted
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
SiamAbdullah wrote:
@JDevlieghere @adrian-prantl, would you review this diff and unblock @cs01 ?
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
cs01 wrote:
Friendly ping @labath and anyone else who has any thoughts
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
28 matches
Mail list logo
