https://github.com/labath commented:
I like what you've done, though it makes it a bit difficult to review. In the future, if you find yourself moving lot of code around, try to separate that from the functional changes into a PR of its own. That makes things flow a lot easier. In this case, it might also have made sense to keep everything in a single file. There's not that much code, and it would avoid this business with namespaces. In fact, I'd suggest moving everything back into a single file anyway, as I think it's the easiest way to resolve the question of naming the namespace. I see what you tried to do, but I don't think adb_client_utils is good name. I think it would make more sense to have an `adb` namespace which has all of the adb-related code, but that would create even more churn. If you just move things back roughly where they originally were, it should also reduce the size of the diff. https://github.com/llvm/llvm-project/pull/145382 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
