llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The surrounding code doesn't use them anymore. This removes the internal usages.
This patch makes the Rows actual values. An alternative would be to make them
unique_ptrs. That would make vector resizes faster
labath wrote:
Thanks for reverting this while I was gone. It looks like there's still some
pointer persistence. I'll take a look at that a bit later...
https://github.com/llvm/llvm-project/pull/132370
___
lldb-commits mailing list
lldb-commits@lists.l
rupprecht wrote:
Saw the same thing running tests internally; reverted.
https://github.com/llvm/llvm-project/pull/132370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Still double checking but i think this may have broken a couple of macOS x86_64
tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10909/
```
TestTsanMultiple.test_dsym/a.out")
runCmd: env TSAN_OPTIONS=abort_on_error=0
output:
runCmd: run
warning: li
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/132370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/132370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> This seems ok to me. I think a good follow-up might be to stop handing out
> row pointers in case somebody tries to store one in the future.
How would you achieve that? By returning copies of the Row? That seems
wasteful..
I don't think there's much risk in persisting row. Th
https://github.com/bulbazord approved this pull request.
This seems ok to me. I think a good follow-up might be to stop handing out row
pointers in case somebody tries to store one in the future. The pointers won't
be stable as the vector resizes, but rows in unique_ptrs seems like a poor use
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/132370
The surrounding code doesn't use them anymore. This removes the internal usages.
This patch makes the Rows actual values. An alternative would be to make them
unique_ptrs. That would make vector resizes faster a
