https://github.com/bulbazord approved this pull request.
This seems ok to me. I think a good follow-up might be to stop handing out row pointers in case somebody tries to store one in the future. The pointers won't be stable as the vector resizes, but rows in unique_ptrs seems like a poor use of memory as well. https://github.com/llvm/llvm-project/pull/132370 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits