[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-27 Thread Louis Dionne via Phabricator via lldb-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-27 Thread Raul Tambre via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://review

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-27 Thread Raul Tambre via Phabricator via lldb-commits
tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre updated this revision to Diff 315847. tambre added a comment. Don't modify third-party checked-in libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 Files: clang/CMakeLists.txt compiler-r

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre marked an inline comment as done. tambre added inline comments. Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ldionne wrote: > I don't think we want to change this. It's a third-party project (which is > inconvenientl

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Louis Dionne via Phabricator via lldb-commits
ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Except for the google-benchmark nit, LGTM. Thanks a lot for the cleanup! Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - -

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Petr Hosek via Phabricator via lldb-commits
phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, lebedev.ri,

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Raul Tambre via Phabricator via lldb-commits
tambre added a reviewer: ldionne. tambre added a comment. ldionne: for libc++ review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94374: [CMake] Remove dead code setting policies to NEW

2021-01-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. LGTM for LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list