ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed.
Except for the google-benchmark nit, LGTM. Thanks a lot for the cleanup! ================ Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ---------------- I don't think we want to change this. It's a third-party project (which is inconveniently checked-in as-is into our tree..). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
