[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth closed this revision. amccarth added a comment. Landed on Tuesday. I must have messed up the `Differential Revision:` line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84815/new/ https://reviews.llvm.org/D84815 ___ lldb-commits ma

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D84815#2203802 , @amccarth wrote: > I tried but failed to make a negative test. LLDB sends the errors message to > stderr when the `target modules

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth updated this revision to Diff 284025. amccarth added a comment. Added test to check locating the PDB either in the original build directory or adjacent to the executable. I tried but failed to make a negative test. LLDB sends the errors message to stderr when the `target modules dump

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth added a comment. Thanks. Working on a test. I found a description of how the Windows debuggers look for PDBs, and it's different than what I expected: 1. The directory that contains the binary 2. The build path embedded in the binary 3. (if enabled) The symbol server cache 4. (if enab

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

labath added a comment. The idea is fine -- the same logic is used in `Symbols::LocateExecutableSymbolFile`. In fact, one of the problems of our pdb support is that it does not use that function to locate symbol files (that way it would also respect the `target.debug-file-search-paths` setting,

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth updated this revision to Diff 281445. amccarth added a comment. Fixed typos in comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84815/new/ https://reviews.llvm.org/D84815 Files: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Index: lldb/source/Plug

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth created this revision. amccarth added reviewers: labath, stella.stamenova. amccarth requested review of this revision. When loading a PE/COFF target, the associated PDB file often wasn't found. The executable module contains a path for the associated PDB file, but people often debug fr