[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG986e3af53bfe: Add Debug Info Size to Symbol Status (authored by aelitashen, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 280261. aelitashen added a comment. Fix run_test to cover every system case and attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basename] +self.assertEqual(program_basena

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen marked an inline comment as done. aelitashen added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basenam

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looks like there is an indentation issue in the test. See inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279936. aelitashen added a comment. Fix the accidentally removed test contents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279351. aelitashen added a comment. Add a white space in Symbols loaded info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-c

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a space before the '(' of the debug info size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:357 + std::ostringstream oss; + oss << "("; + oss << std

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279303. aelitashen added a comment. Remove white space for test_module_event Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-cl

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace accepted this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:65 +@skipIfWindows +@ skipUnlessDarwin +@skipIfRemote remove this whitespace Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278922. aelitashen added a comment. Add TODO comment for Linux, Use ostringstream for Debug Info Size message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. The logic looks very good, just some final comments and the code will be high quality Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:66

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278900. aelitashen added a comment. Merge if statements in GetDebugInfoSizeInSection() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-for

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278898. aelitashen added a comment. Merge Codes and Improve Readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-clang-f

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278894. aelitashen added a comment. Create help function in tests for code re-use. Take care of both macOS and Linux system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added a comment. @clayborg, the tests will fail on linux because the Makefile is expecting a .dsym file. I think it's okay if she does it just for Darwin and then I update the test to cover also linux, as I have my linux already well set up. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So you should revert any clang format changes that are not in modified lines of source, mostly revert a lot of lines in lldb-vscode.cpp. Comment at: lldb/test/

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:333-335 + if (section_name.startswith(".debug") || section_name.startswith("__debug")) +debug_info_size += section.GetFileByteSize(); + if (section_name.startswith(".apple") || section_name.star

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278631. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests added are only for macOS, Walter will help me write tests on Linux. This update optimize the code and apply git clang format. Repository:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:40-41 self.assertEqual('Symbols not found.', program_module['symbolStatus']

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278591. aelitashen added a comment. Add Test for Debug Info Size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aprantl added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:353 + if (debug_info < 1024) { +sprintf(debug_info_size, " (%lluKB)", debug_info); + } else if (debug_info < 1024*1024) { clayborg wrote: > Use the PRIu64 macro here

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. See inlined comments. You will also need to fix the test for this since it will now fail as the "symbolStatus" now contains the size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:342-349 +uint64_t d

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please include a test case Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:351-362 + char debug_info_size[10]; + if (debug_info < 1024) { +spri

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. Debug Info Size is displayed with Symbol Status Message. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83731 Files: