clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks like there is an indentation issue in the test. See inline comments.
================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61
+ active_modules = self.vscode.get_active_modules()
+ program_module = active_modules[program_basename]
+ self.assertEqual(program_basename, program_module['name'])
+ self.assertEqual(program, program_module['path'])
+ self.assertIn('symbolFilePath', program_module)
+ self.assertEqual(symbols_path, program_module['symbolFilePath'])
+ self.assertIn('addressRange', program_module)
----------------
Unindent everything after the self.waitUntil()? Otherwise we are not testing
the program, symbolFilePath and addressRange on symbols with size.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83731/new/
https://reviews.llvm.org/D83731
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
