[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added a comment. Unfortunately I've had to revert this because it was making a number of vscode tests hang nondeterministically: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/10557, http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/10545, http://lab.llvm.org:8011

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3609b0ec685: Add terminateCommands to lldb-vscode protocol (authored by aadsm, committed by António Afonso ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:447 +] +terminateCommands = ['expr 4+2'] +self.launch(program=program, The expression parser can be quite involved even for simple thin

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 264143. aadsm added a comment. Updated README.md, package.json to document the new option. Also refactored the test support a bit to allow easier testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

clayborg added a comment. might be nice to have "disconnectCommands" at some point if we ever need them too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 __

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D79726#2031817 , @aadsm wrote: > > I gotta say I don't understand the difference between "exit" and > > "terminate" commands, as both seem to happen

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disconnect: +self.vscode.req

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251 def cleanup(): -self.vscode.request_disconnect(terminateDebuggee=True) +if disco

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm added a comment. > I gotta say I don't understand the difference between "exit" and "terminate" > commands, as both seem to happen pretty at once. Is the difference that > "exit" commands are run only when the inferior exits freely on its own, and > not when we forcefully kill it? And tha

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath added a comment. I gotta say I don't understand the difference between "exit" and "terminate" commands, as both seem to happen pretty at once. Is the difference that "exit" commands are run only when the inferior exits freely on its own, and not when we forcefully kill it? And that "term

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263299. aadsm added a comment. Rebase and remove unwanted debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files: lldb/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm marked 2 inline comments as done. aadsm added a comment. I chose the name terminate because this happens just before the `terminated` event is sent back to the client. Comment at: lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py:49-67 +@skipIfDarwin @

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

wallace added a comment. I don't know if terminate is the best name, as it could seem related to the inferior. What about finalize? It reminds me of the try/catch/finalize words, and it's harder to associate it with the inferior's own exit event. Comment at: lldb/test/API/too

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm created this revision. aadsm added reviewers: clayborg, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Adding this in line with "stopCommands" and "exitCommands" s

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

aadsm updated this revision to Diff 263206. aadsm added a comment. Remove debugging leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/l