aadsm marked 2 inline comments as done.
aadsm added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py:250-251
def cleanup():
- self.vscode.request_disconnect(terminateDebuggee=True)
+ if disconnect:
+ self.vscode.request_disconnect(terminateDebuggee=True)
self.vscode.terminate()
----------------
labath wrote:
> What's the purpose of this argument? To ensure a clean shutdown? Would it be
> possible to make the function smart enough to detect the right thing to do
> when cleaning up?
it indicates if the process should be killed or not when lldb-vscode
disconnects from it.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:777
auto state = process.GetState();
-
+ g_vsc.RunTerminateCommands();
switch (state) {
----------------
labath wrote:
> How about moving this to line ~801 so that it is sent *after* the inferior is
> killed, similar to how you above perform the commands after receiving the
> exit event?
yap, that does make sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79726/new/
https://reviews.llvm.org/D79726
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
