[Lldb-commits] [PATCH] D75418: tab completion for process signal

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bba1c22e77a: tab completion for process signal (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248784. MrHate added a comment. Added a test case where test "process signal" without a running process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I would like to have a test for this without a running process but otherwise this LGTM. Thanks a lot! Comment at: lldb/test/API/functionalities/completion/Te

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248088. MrHate edited the summary of this revision. MrHate added a comment. Removed individual execution context updating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/Command

[Lldb-commits] [PATCH] D75418: tab completion for process signal

jingham added a comment. I think this is just a bug in argument completion. The CommandInterpreter needs to sync up with the currently selected target/process/thread/frame before running commands. It COULD do that by having every API that changes the selected T/P/T/F above notify the CommandIn

[Lldb-commits] [PATCH] D75418: tab completion for process signal

labath added subscribers: jingham, labath. labath added a comment. In D75418#1902266 , @MrHate wrote: > In order to process completion successfully whenever we've got a valid > process, I will update the current execution context both in `m_interpreter`

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247786. MrHate added a comment. removed unnecessary assignment in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp lldb/test/API/functionalities/co

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247785. MrHate added a comment. Update the current execution context, then get signals from the current process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProc

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate added a comment. Thanks for pointing out my misunderstanding on the Unix signals, and fetching the list of valid signals from backend is always a better way indeed. However, getting the current process from the current context `m_exe_ctx` which is got from `m_interpreter` will cause an is