This revision was automatically updated to reflect the committed changes.
Closed by commit rG651b5e725ee6: Modernize TestThreadStepOut.py (authored by
jingham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69453/new/
https://reviews.llvm.org/D69453
jingham marked 4 inline comments as done.
jingham added inline comments.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/thread/step_out/TestThreadStepOut.py:136
+(self.inferior_target, self.inferior_process, thread, bkpt) =
lldbutil.run_to_source_breakp
jingham updated this revision to Diff 226772.
jingham added a comment.
Addressed review comments.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69453/new/
https://reviews.llvm.org/D69453
Files:
lldb/packages/Python/lldbsuite/test/functionalities/thread/step
aprantl added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:781
-test.assertTrue(len(threads) == 1, "Expected 1 thread to stop at
breakpoint, %d did."%(len(threads)))
+num_threads = len(threads)
+if only_one_thread:
t
aprantl added a comment.
Thanks! Nitpicking inside.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/thread/step_out/TestThreadStepOut.py:136
+(self.inferior_target, self.inferior_process, thread, bkpt) =
lldbutil.run_to_source_breakpoint(
+
jingham created this revision.
Herald added subscribers: lldb-commits, JDevlieghere, abidh.
Herald added a project: LLDB.
This test was timing out on the bots occasionally, so I was poking around at
it. I didn't see any obvious reason why it would stall, but it had a slightly
odd way of rendezv
