[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

2019-10-11 Thread Haibo Huang via Phabricator via lldb-commits
hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > tatyana-krasnukha wrote: > >

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

2019-10-11 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > hhb wrote: > >

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

2019-10-11 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. Fixed by reverting the initial commit. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.d

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

2019-10-10 Thread Haibo Huang via Phabricator via lldb-commits
hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) hhb wrote: > tatyana-krasnukha wrote: > > This command p

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

2019-10-10 Thread Haibo Huang via Phabricator via lldb-commits
hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > This command produces an inco