This revision was automatically updated to reflect the committed changes.
Closed by commit rL373564: factor out an abstract base class for File (authored
by lawrence_danna, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
lawrence_danna updated this revision to Diff 222851.
lawrence_danna marked 2 inline comments as done.
lawrence_danna added a comment.
rm NativeFile::make_shared
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68317/new/
https://reviews.llvm.org/D6831
lawrence_danna added inline comments.
Comment at: lldb/include/lldb/Host/File.h:377-381
+ template
+ static std::shared_ptr make_shared(Args... args) {
+return std::static_pointer_cast(
+std::make_shared(args...));
+ }
labath wrote:
> Please delet
labath added a comment.
Makes sense to me, just delete the custom make_shared stuff.
Comment at: lldb/include/lldb/Host/File.h:377-381
+ template
+ static std::shared_ptr make_shared(Args... args) {
+return std::static_pointer_cast(
+std::make_shared(args...));
+
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added a project: LLDB.
lawrence_danna added a parent revision: D68181: SBDebugger::SetInputFile,
SetOutputFile, etc..
lawrence_danna added a child revision: D68188: allow arbitrary pyth
