lawrence_danna added inline comments.
================
Comment at: lldb/include/lldb/Host/File.h:377-381
+ template <typename... Args>
+ static std::shared_ptr<File> make_shared(Args... args) {
+ return std::static_pointer_cast<File>(
+ std::make_shared<NativeFile>(args...));
+ }
----------------
labath wrote:
> Please delete this stuff, and just use regular std::make_shared. (BTW,
> shared_ptr<Derived> is implicitly convertible to shared_ptr<Base>)
Huh, I swear when i tried that yesterday the compiler was saying it wasn't
implicitly convertible. Now, it is as you say. Must have been gremlins.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68317/new/
https://reviews.llvm.org/D68317
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
