[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath added a comment. In D67965#1684297 , @sylvestre.ledru wrote: > @labath > I am building with AVR as experimental target and this change probably broke > the build. > > Could you please have a look? > thanks Thanks for the heads up. r372998 ough

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

sylvestre.ledru added a comment. @labath I am building with AVR as experimental target and this change probably broke the build. In file included from /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL372862: Have ABI plugins vend llvm MCRegisterInfo data (authored by labath, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project:

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/lldb/Target/ABI.h:141 protected: - // Classes that inherit from ABI can see and modify these - ABI(lldb::ProcessSP process_sp) { -if (process_sp.get()) -m_process_wp = proces

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for the explanation. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67965/new/ https://reviews.llvm.org/D67965 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67965/new/ https://reviews.llvm.org/D67965 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

aprantl added inline comments. Comment at: source/Plugins/ABI/CMakeLists.txt:1 -add_subdirectory(SysV-arm) -add_subdirectory(SysV-arm64) -add_subdirectory(SysV-hexagon) -add_subdirectory(SysV-ppc) -add_subdirectory(SysV-ppc64) -add_subdirectory(SysV-mips) -add_subdirectory(SysV-m

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath marked an inline comment as done. labath added inline comments. Comment at: source/Target/ABI.cpp:216 + +std::unique_ptr ABI::MakeMCRegisterInfo(const ArchSpec &arch) { + std::string triple = arch.GetTriple().getTriple(); JDevlieghere wrote: > Should thi

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

tatyana-krasnukha added inline comments. Comment at: include/lldb/Target/ABI.h:141 protected: - // Classes that inherit from ABI can see and modify these - ABI(lldb::ProcessSP process_sp) { -if (process_sp.get()) -m_process_wp = process_sp; + ABI(lldb::ProcessSP p

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

JDevlieghere added inline comments. Comment at: source/Target/ABI.cpp:216 + +std::unique_ptr ABI::MakeMCRegisterInfo(const ArchSpec &arch) { + std::string triple = arch.GetTriple().getTriple(); Should this return an llvm::Expected instead? I understand it will

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath created this revision. labath added reviewers: jasonmolenda, aprantl, JDevlieghere, tatyana-krasnukha. Herald added subscribers: atanasyan, kbarton, mgorny, nemanjai. I was recently surprised to learn that there is a total of 2 (two) users of the register info definitions contained in the A