tatyana-krasnukha added inline comments.
================
Comment at: include/lldb/Target/ABI.h:141
protected:
- // Classes that inherit from ABI can see and modify these
- ABI(lldb::ProcessSP process_sp) {
- if (process_sp.get())
- m_process_wp = process_sp;
+ ABI(lldb::ProcessSP process_sp, std::unique_ptr<llvm::MCRegisterInfo>
info_up)
+ : m_process_wp(process_sp), m_mc_register_info_up(std::move(info_up)) {
----------------
Since this and derived class's constructors are protected/private it can make
sense to make their parameters r-value and not rely on copy elision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67965/new/
https://reviews.llvm.org/D67965
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
