labath added a comment.
Since this (unlike most of your other patches in this series) is definitely
adding new functionality, it would be good to accompany it with a test. The
simplest way to do that should be via something like `yaml2obj && lldb-test
object-file | FileCheck`. I'd recommend loo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL372657: [LLDB] [PECOFF] Recognize arm64 executables
(authored by mstorsjo, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:202
+ case MachineArm64:
+spec.SetTriple("aarch64-pc-windows");
+specs.Append(module_s
mstorsjo created this revision.
mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith.
Herald added subscribers: JDevlieghere, kristof.beyls.
Herald added a project: LLDB.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D67912
Files:
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFi
