labath added a comment.

Since this (unlike most of your other patches in this series) is definitely 
adding new functionality, it would be good to accompany it with a test. The 
simplest way to do that should be via something like `yaml2obj && lldb-test 
object-file | FileCheck`. I'd recommend looking at 
`lit/Modules/MachO/lc_version_min.yaml` for inspiration.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67912/new/

https://reviews.llvm.org/D67912



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to