[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. I mean, when a process is not able to allocate memory, it cannot JIT, but still can interpret. Should the test report failure in this case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 ___

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor added a comment. In D67227#1730144 , @tatyana-krasnukha wrote: > Another problem of the `test_ir_interpreter` is that it fails even when JIT > fails despite it should test the interpreter. Well, it also tests that the IRInterpreter is equival

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. Another problem of the `test_ir_interpreter` is that it fails even when JIT fails despite it should test the interpreter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 _

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. On Fedora 31 x86_64 (that is with `python3-3.7.4-5.fc31.x86_64`) I get: FAIL: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64)

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor updated this revision to Diff 220857. teemperor marked 7 inline comments as done. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 Files: lldb/packages/Python/lldbsuite/test/commands/e

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:48 +self.type = type +self.decl_expr = type + " " + self.name + " = " + str(self.value) +self.unsigned_type =

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor updated this revision to Diff 219059. teemperor added a comment. - Relaxed can_handle_operands that it allows shifting unsigned large values (produced by initialising them with negative signed values). - Now checking for 32bit instead of 7 (thanks Shafik!) CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if r

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/ir-interpreter/TestIRInterpreter.py:54 +# Shifting longer than size of a type also doesn't work. +if rhs.value <= 0 or rhs.value >= 7: +

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. There are a bunch of arithmetic and comparison instructions supported by the IRInterpreter and we currently don't test these at all in the test