[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL368069: Various build fixes for lldb on MinGW (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

jingham added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; labath wrote: > amccarth wrote: > > hhb wrote: > > > amccarth wrote: > > > > Nothing in the rest of this .cpp file uses

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > hhb wrote: > > amccart

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213505. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; hhb wrote: > amccarth wrote: > > Nothing in the rest of this .cpp file uses

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213448. hhb marked 4 inline comments as done. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/Pos

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the > `#define` instead of executing

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

amccarth added a comment. Yes, zturner isn't as active here as he was before. I'm happy to review patches regarding LLDB on Windows, even though I don't know much about Mingw. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:19 #endif +#ifdef __MINGW32

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

labath added subscribers: stella.stamenova, amccarth, labath. labath added a comment. I took @xbolva00's suggestion one step further, and removed the usleep and the related compat code in r367814. So, some of your changes are no longer needed once you rebase past that. I have a couple of additi

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

xbolva00 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:19 #endif +#ifdef __MINGW32__ +// usleep Maybe drop usleep and use C++’s https://en.cppreference.com/w/cpp/thread/sleep_for ? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

clayborg added a comment. In D65691#1613395 , @mstorsjo wrote: > As context (I haven't followed lldb almost at all), what's the general status > of lldb on windows - generally working, or still a work in progress? Does it > work with dwarf debug info in

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

mstorsjo added a reviewer: zturner. mstorsjo added a comment. As context (I haven't followed lldb almost at all), what's the general status of lldb on windows - generally working, or still a work in progress? Does it work with dwarf debug info in COFF (as commonly used in mingw environments), in

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem.cpp lldb/source/Initializati