labath added subscribers: stella.stamenova, amccarth, labath. labath added a comment.
I took @xbolva00's suggestion one step further, and removed the usleep and the related compat code in r367814. So, some of your changes are no longer needed once you rebase past that. I have a couple of additional small comments inline, but other than that, this seems fine. I'm not sure how active is @zturner these days (@amccarth and @stella.stamenova are probably better reviewers for windows stuff now), but this seems pretty straight-forward, so I don't think we have to wait for them. ================ Comment at: lldb/source/Initialization/SystemInitializerCommon.cpp:28 #include "lldb/Host/windows/windows.h" +// for _CrtSetReportMode +#include <crtdbg.h> ---------------- In r346625, we deleted all/most comments like this. Probably best to not introduce new ones... ================ Comment at: lldb/tools/driver/Platform.h:20 +// pid_t +#include <sys/types.h> +#endif ---------------- It looks like we already have the `HAVE_SYS_TYPES_H` macro, which we can use for this purpose, so I'd use that, and move it out of the `_MSC_VER` block as we should really include this header on other platforms too (but we probably haven't done that because it got included transitively already...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits