[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. In D65611#1615161 , @JDevlieghere wrote: > We definitely need the VFS change for the reproducers, no argument there. My > earlier comment was more about the change in general, orthogonal to the > reproducers. Ah, I see. Thanks

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1615083 , @labath wrote: > So what if the user doesn't do `lldb ./foo` but instead does `file ./foo` at > the lldb comand prompt? Then, you'll be back at square one as far as > reproducers are concerned... We def

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. or `lldb -o "file ./foo"` for that matter. I've seen people who are unaware of `-O` do that when they want to execute stuff before the target is set... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 __

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. So what if the user doesn't do `lldb ./foo` but instead does `file ./foo` at the lldb comand prompt? Then, you'll be back at square one as far as reproducers are concerned... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D656

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

clayborg added a comment. In D65611#1615018 , @JDevlieghere wrote: > In D65611#1613052 , @clayborg wrote: > > > Also be careful if the user uses a symlink to not resolve the link. If a > > user tries to debug clan

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1613052 , @clayborg wrote: > Also be careful if the user uses a symlink to not resolve the link. If a user > tries to debug clang++: > > $ ls -AFlG > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDef

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

clayborg added a comment. Also be careful if the user uses a symlink to not resolve the link. If a user tries to debug clang++: $ ls -AFlG /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang* -rwxr-xr-x 1 root wheel 8156 Jul 12 21:48 /Applica

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1611724 , @labath wrote: > The details of how our FS capture works have unfortunately, swapped out of my > memory, but... isn't this the sort of thing that should already be handled by > the filesystem capture/repl

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. The details of how our FS capture works have unfortunately, swapped out of my memory, but... isn't this the sort of thing that should already be handled by the filesystem capture/replay machinery? It sounds to me like it could/should remember what the CWD at the time of

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere updated this revision to Diff 212924. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 Files: lldb/lit/Driver/TestTarget.test lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp ==

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

jingham added a comment. IIRC both GetPath and ResolvePath return the number of characters it would take to actually resolve the path. 128 is actually pretty short, so you should check the result and malloc a buffer of the return + 1 if 128 ends up not being enough. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

jingham added a comment. If you just want the path and don't need the FileSpec, you can call the static SBFileSpec::ResolvePath. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 ___ lldb-commits mail

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere updated this revision to Diff 212916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 Files: lldb/lit/Driver/TestTarget.test lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp ==

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath, jingham, clayborg, mgorny. JDevlieghere added a project: LLDB. Herald added a subscriber: teemperor. When invoking lldb on the command line with a binary, lldb will construct a command stream to create the target.