[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

mgrang added a comment. Herald added a subscriber: JDevlieghere. Hi @jfb This patch results in a compiler crash when building a simple C program on a Windows X86 Debug build. I have filed this issue to track it. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb closed this revision. jfb added a comment. https://reviews.llvm.org/rL367282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1605523 , @rnk wrote: > I have concerns that some of the patches that you landed prior to this will > cause issues with old versions of MSVC, but in isolation, this is fine, and > if anyone complains, we can address it on a

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have concerns that some of the patches that you landed prior to this will cause issues with old versions of MSVC, but in isolation, this is fine, and if anyone complains, we can address it on a ca

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1603431 , @BillyONeal wrote: > (In fact I observe many patterns in this review like: > > enum { Foo = alignof(void*); } > aligned_storage_t<1234, Foo> x; > > and then a bunch of casting to treat it as a char buffer; if it wa

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb updated this revision to Diff 212252. jfb added a comment. Significantly simplify the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 Files: llvm/include/llvm/Support/AlignOf.h llvm/unittests

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. (In fact I observe many patterns in this review like: enum { Foo = alignof(void*); } aligned_storage_t<1234, Foo> x; and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack: align

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. In D65249#1603335 , @jfb wrote: > @rnk: how about I add a bit of code that wraps `aligned_storage` on all > platforms except MSVC (where I'd implement it as Billy suggests). That would > mean updating all the uses of `aligned_

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. In D65249#1603278 , @BillyONeal wrote: > > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? > > aligned_storage is still capped at what the library can fake with unions. It > would be an ABI break to change it to

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

BillyONeal added a comment. > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? aligned_storage is still capped at what the library can fake with unions. It would be an ABI break to change it to use alignas, so things where the x86 stack temporarily breaks T's usual alignme

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a subscriber: BillyONeal. jfb added a comment. In D65249#1603133 , @rnk wrote: > I still think this concern applies: > https://reviews.llvm.org/D64417#1576675 > > I'm not sure how to track down an 19.11 release to test if we can pass > std::ali

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

rnk added a comment. I still think this concern applies: https://reviews.llvm.org/D64417#1576675 I'm not sure how to track down an 19.11 release to test if we can pass std::aligned_storage values through function calls on x86. We might be better off raising the minimum to 19.14, which is a more

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb created this revision. jfb added a reviewer: chandlerc. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, jkorous, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change-IWk6CtRl45h6 The rest is side-show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249