[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL362981: [Target] Remove Process::GetObjCLanguageRuntime (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203877. xiaobai added a comment. ObjCLanguageRuntime::GetObjCLanguageRuntime -> ObjCLanguageRuntime::Get CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h i

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( labath wrote: > xiaobai

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

labath added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( xiaobai wrote: > labath wrote: > > compnerd wrote: > > > I think it

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203872. xiaobai added a comment. Simplify a change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h include/lldb/Target/Process.h include/lldb/lldb-forwa

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( labath wrote: > compnerd

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

labath added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( compnerd wrote: > I think it would be nice to just call this `Get`

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

compnerd added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202 + static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) { +return llvm::cast_or_null( I think it would be nice to just call this `Get` (and we could ha

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai updated this revision to Diff 203714. xiaobai added a comment. Small cleanups CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63052/new/ https://reviews.llvm.org/D63052 Files: include/lldb/Target/ObjCLanguageRuntime.h include/lldb/Target/Process.h include/lldb/lldb-forward.

[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

xiaobai created this revision. xiaobai added reviewers: compnerd, davide, JDevlieghere, jingham, aprantl, labath. Herald added a subscriber: arphaman. In an effort to make Process more language agnostic, I removed GetCPPLanguageRuntime from Process. I'm following up now with an equivalent change