[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath added a comment. In D62852#1537529 , @kwk wrote: > > This patch fixes a couple of existing tests, > > @labath can you please tell which tests are fixed by this commit exactly? I > try to reproduce an issue with a test that (potentially under load)

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

kwk added a comment. > This patch fixes a couple of existing tests, @labath can you please tell which tests are fixed by this commit exactly? I try to reproduce an issue with a test that (potentially under load) used tp sometimes hang. Now it does no longer do that and I wonder if your change h

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

This revision was automatically updated to reflect the committed changes. Closed by commit rL362586: Ignore DIEs in the skeleton unit in a DWO scenario (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the dw

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath updated this revision to Diff 202986. labath added a comment. - avoid parsing the extra DIEs in the first place CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62852/new/ https://reviews.llvm.org/D62852 Files: lit/SymbolFile/DWARF/split-dwarf-inlining.cpp source/Plugins/Symbol

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the dwo file +// simultaneously. We also

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the dwo file +// simultaneously. We also

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. r362103 exposed a bug, where we could read incorrect data if a skeleton unit contained more than the single unit DIE. Clang emits these kinds of units with -fsplit-dwarf-inlining (which is also the default). Ch