labath added a comment. In D62852#1537529 <https://reviews.llvm.org/D62852#1537529>, @kwk wrote:
> > This patch fixes a couple of existing tests, > > @labath can you please tell which tests are fixed by this commit exactly? I > try to reproduce an issue with a test that (potentially under load) used tp > sometimes hang. Now it does no longer do that and I wonder if your change has > anything to do with that. > > Here's the test call I'm talking about: > > cd ~/llvm/lldb/test/ > > LD_LIBRARY_PATH=$LD_LIBRARY_PATH:~/llvm-builds/relwithdebinfo-ninja-clang-gold-ccache-distcc/lib > python dotest.py \ > -v \ > --executable > ~/llvm-builds/relwithdebinfo-ninja-clang-gold-ccache-distcc/bin/lldb \ > -f TestVSCode_setBreakpoints.test_functionality \ > ../../lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint > I don't remember which tests exactly were broken by this, but I know that all of them were using `__attribute__((always_inline))`, and only the dwo variant was broken. `TestVSCode_setBreakpoints` does not fit either of the two criteria, and was flaky even before the change which "broke" the dwo+inline combo, so I would be very surprised if this patch had any effect on that test... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62852/new/ https://reviews.llvm.org/D62852 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
