This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361362: Add AST logging (authored by martong, committed
by ).
Herald added a subscriber: teemperor.
Changed prior to commit:
https://reviews.llvm.org/D62061?vs=200666&id=200670#toc
Repository:
rLL
martong updated this revision to Diff 200666.
martong added a comment.
- Remove superflous '.c_str()'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62061/new/
https://reviews.llvm.org/D62061
Files:
lldb/include/lldb/Utility/Logging.h
lldb/sour
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM outside of Jonas's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62061/new/
https://reviews.llvm.org/D62061
__
JDevlieghere added inline comments.
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:968
+ from->getDeclKindName(), static_cast(to),
+ name_string.c_str(), static_cast(from));
+
The macro uses llvm's format library, so you can o
martong added inline comments.
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:956
+ Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+ if (log_ast) {
+std::string name_string;
JDevlieghere wrote:
> Why not `if (Log* lo
martong updated this revision to Diff 200446.
martong marked 4 inline comments as done.
martong added a comment.
- Change to if(Log *log = ...)
- Use LLDB_LOG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62061/new/
https://reviews.llvm.org/D62061
JDevlieghere added inline comments.
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:956
+ Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+ if (log_ast) {
+std::string name_string;
Why not `if (Log* log_ast =
lldb_pri
martong created this revision.
martong added a reviewer: shafik.
Herald added subscribers: lldb-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a project: LLDB.
Log the AST of the TU associated with LLDB's `expr` command, once a declaration
is completed
Repository:
rG LLVM Github
