martong added inline comments.
================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:956
+ Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST));
+ if (log_ast) {
+ std::string name_string;
----------------
JDevlieghere wrote:
> Why not `if (Log* log_ast =
> lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST))`
Sure, changed that.
================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:963
+ }
+ log_ast->Printf("==== [ClangASTImporter][TUDecl: %p] Imported "
+ "(%sDecl*)%p, named %s (from "
----------------
JDevlieghere wrote:
> You can use the `LLDB_LOG` macro which provides a much nicer interface.
Ok thanks for pointing it out. Changed to use it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62061/new/
https://reviews.llvm.org/D62061
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
