[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

shafik added a comment. Herald added a subscriber: ormris. It looks like this commit introduced undefined behavior via a misaligned load see this log from lldb sanitized bot on green dragon http://lab.llvm.org:8080/green/view/LLDB/job/lldb-sanitized/2050/testReport/junit/lldb-Suite/functionaliti

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356573: Fix UUID decoding from minidump files (authored by gclayton, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533 +self.assertEqual(2, len(modules)) +self.verify_module(modules[0], "/tmp/a", None) +self.verify_module(modules[1], "/tm

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

clayborg marked an inline comment as done. clayborg added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533 +self.assertEqual(2, len(modules)) +self.verify_module(modules[0], "/tmp/a", None)

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

serge-sans-paille added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533 +self.assertEqual(2, len(modules)) +self.verify_module(modules[0], "/tmp/a", None) +self.verify_module(modul

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. I have some comments inline and below, but none of them is really substantial. In D59433#1431602 , @clayborg wrote: > In D59433#1431

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

clayborg added a comment. In D59433#1431488 , @zturner wrote: > "MinidumpNew" is a little bit vague. What's "new" about it? Is there a way > we could come up with a better name? This was an existing file that I just added new tests to, and it seemed t

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

zturner added a comment. "MinidumpNew" is a little bit vague. What's "new" about it? Is there a way we could come up with a better name? As an aside, since there's no interactivity in these tests, they seem like a good candidate for lit/Minidump, with 1 file for each test. Something like:

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

clayborg created this revision. clayborg added reviewers: zturner, labath. Herald added a subscriber: javed.absar. Herald added a reviewer: serge-sans-paille. This patch fixes: - UUIDs now don't include the age field from a PDB70 when the age is zero. Prior to this they would incorrectly contain