labath added inline comments.
================ Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533 + self.assertEqual(2, len(modules)) + self.verify_module(modules[0], "/tmp/a", None) + self.verify_module(modules[1], "/tmp/b", None) ---------------- clayborg wrote: > serge-sans-paille wrote: > > labath wrote: > > > Am I right in thinking that if I have an object file called `/tmp/a` on > > > my system, then lldb will pick it up (and it's build-id), causing this > > > test to fail ? If that's the case then it would be better to use some > > > path which is less likely to exist. > > I second this. https://docs.python.org/3/library/tempfile.html provides > > ways to create such temporary names. > These have strict UUID values that must match and the value is hard coded > into the minidump files. So even if there is such a file, the UUID won't > match. That is true for other files, but is it true about this one? I specifically highlighted this instance one because it tests the uuid-not-present case (in which case I believe lldb will interpret that as matching any object file). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59433/new/ https://reviews.llvm.org/D59433 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
