This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL354033: Move UnwindTable from ObjectFile to Module (authored
by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Chan
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: include/lldb/Core/Module.h:1108-1110
+ llvm::Optional m_unwind_table; /// < Table of FuncUnwinders
+ /// objects created for this
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Just a question of if we need an optional unwind table instance instead of just
an instance. I am fine either way.
Comment at: include/lldb/Core/Module.h:1108-1110
+ ll
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Core/Module.h:709
+ //--
+ UnwindTable *GetUnwindTable();
+
clayborg wrote:
> I would vote to return
labath updated this revision to Diff 186599.
labath added a comment.
Herald added a subscriber: jdoerfert.
Changed Module::GetUnwindTable to return a referece. I also changed the
UnwindTable to internally store a Module& (instead of ObjectFile&), to make sure
it always has something to hold on to.
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You changed the API to return a pointer which can be NULL so we either need to
check all returns for this or change the API to return a reference to a default
constructed UnwindT
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
This is a preparatory step to enable adding extra unwind strategies by
symbol file plugins. This has been discussed on the lldb-dev maili
