labath marked an inline comment as done.
labath added inline comments.

================
Comment at: include/lldb/Core/Module.h:709
+  //------------------------------------------------------------------
+  UnwindTable *GetUnwindTable();
+
----------------
clayborg wrote:
> I would vote to return a "UnwindTable&" and make a const and non const 
> version of this. Otherwise we have to NULL check any call to this API.
There isn't much point in having a const version of this, as all UnwindTable 
methods are non-const.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58129/new/

https://reviews.llvm.org/D58129



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to