[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350546: Use the minidump exception record if present (authored by lemo, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

lemo updated this revision to Diff 180515. lemo added a comment. Incorporating Pavel's suggestions (range-based loop, explicit type instead of auto) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 Files: lit/Minidump/Windows/Sigsegv/Inputs/si

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

On 04/01/2019 17:48, Zachary Turner wrote: For those kinds of cases, we could use obj2yaml and check in yaml right? Fwiw I tried to round-trip an exe through obj->yaml->obj recently and the resulting exe was incorrect but it was close, so I think there’s only some small fixes needed. I agre

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

labath accepted this revision. labath added a comment. Looks fine to me (but please wait for an ack from Zachary). Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:313 - for (lldb::tid_t tid = 0; tid < num_threads; ++tid) { + for (size_t t_index = 0; t_index

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Great! I can see how we can put this to good use. In the meantime, I'd like to submit this change as is - the included input files are intended to be reused for future test cases as well (they are extracted from my larger change to add support for the native PDB reader + minidumps). On Fri, Jan 4

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 12:37 PM, Leonard Mosescu wrote: > > Sounds very useful. Are you planning to add it to the LLDB repository? Yes > > > On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton > wrote: > > >> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu >

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Sounds very useful. Are you planning to add it to the LLDB repository? On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton wrote: > > > On Jan 4, 2019, at 9:45 AM, Leonard Mosescu wrote: > > I have a minidump generator if you need me to make any specific minidump >> files for you. >> > > Maybe not in

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

The main goal for this minidump module was so I could load it into lldb and then run "minidump --save" to save the current process as a minidump file since I like minidump files better than core files... It just happens to work for generating very small and targeted minidump files for testing as

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Waiiit a second. Why don't we just teach obj2yaml and yaml2obj to round-trip minidumps? This way you could run it on a minidump, then hand-edit it to customize some bits you want to change, then check in the yaml. On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton wrote: > > On Jan 4, 2019, at 9

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu wrote: > > I have a minidump generator if you need me to make any specific minidump > files for you. > > Maybe not in this case, but it seems an interesting idea. What are the > capabilities of this generator tool? I can generate threads context

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

You're right, it wouldn't. I didn't think of that. I guess the obj -> yaml round-tripping would be the only way in that case, and the tool would need to be fixed first so that it can round trip executable object files. On Fri, Jan 4, 2019 at 9:46 AM Leonard Mosescu wrote: > ouldn’t we have lld

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> > ouldn’t we have lldb generate the mini dump itself as the first step of > the test? > How would this work cross-platform? On Fri, Jan 4, 2019 at 8:48 AM Zachary Turner wrote: > For those kinds of cases, we could use obj2yaml and check in yaml right? > Fwiw I tried to round-trip an exe throu

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> > I have a minidump generator if you need me to make any specific minidump > files for you. > Maybe not in this case, but it seems an interesting idea. What are the capabilities of this generator tool? On Thu, Jan 3, 2019 at 3:49 PM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

lemo updated this revision to Diff 180263. lemo added a comment. Removed sigsegv.exe from the test inputs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 Files: lit/Minidump/Windows/Sigsegv/Inputs/sigsegv.cpp lit/Minidump/Windows/Sigsegv/Inp

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

For those kinds of cases, we could use obj2yaml and check in yaml right? Fwiw I tried to round-trip an exe through obj->yaml->obj recently and the resulting exe was incorrect but it was close, so I think there’s only some small fixes needed. In regards to your previous response, couldn’t we have l

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

labath added a comment. In D56293#1345790 , @zturner wrote: > I don't think we can check in an executable file, we should try to compile it > on the spot. We have 1-2 existing unit tests that check in an exe and we > occasionally get reports that people

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

labath added a comment. In D56293#1345790 , @zturner wrote: > Is there something about this executable that makes it impractical to compile > on the fly using the `%build` substitution? I think the impractical part comes when you need to use that compil

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

clayborg added a comment. I have a minidump generator if you need me to make any specific minidump files for you. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 ___ lldb-c

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. I don't think we can check in an executable file, we should try to compile it on the spot. We have 1-2 existing unit tests that check in an exe and we occasionally get reports tha

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

lemo created this revision. lemo added reviewers: labath, zturner. lemo added a project: LLDB. Herald added subscribers: jfb, abidh. If the minidump contains a saved exception record use it automatically. (This patch is cherry picked from the larger https://reviews.llvm.org/D55142) Repository: