labath added a comment. In D56293#1345790 <https://reviews.llvm.org/D56293#1345790>, @zturner wrote:
> I don't think we can check in an executable file, we should try to compile it > on the spot. We have 1-2 existing unit tests that check in an exe and we > occasionally get reports that peoples' virus scanners flag them as trojans, > even though they obviously aren't. In any case, I've been meaning to remove > those tests, so I think we should set a precedent that executable binaries > are never checked in. While I agree that a checked-in exe shouldn't be needed in this (and most other) cases, I am not sure about the policy in general. For example, I can see a case for having a bunch of badly corrupted binaries (things like corrupted section headers, overlapping sections in the file; things that even yaml2obj will have trouble generating) and then a test that makes sure we do something reasonable (e.g., not crash) when opening them. These are exactly the kind of files that make paranoid virus scanners sound the alarm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
