If you do decide to unsilence it, then just mark those skip and file bugs
for them being flaky.
On Fri, Dec 14, 2018 at 11:11 AM Stella Stamenova
wrote:
> An unexpected pass makes the bot red. I might un-silence it despite the
> couple of issues left anyway, but it’s something to be aware of.
>
An unexpected pass makes the bot red. I might un-silence it despite the couple
of issues left anyway, but it’s something to be aware of.
Thanks,
-Stella
From: Zachary Turner
Sent: Friday, December 14, 2018 11:04 AM
To: Stella Stamenova
Cc: reviews+d55575+public+5ea6161324294...@reviews.llvm.or
An unexpected pass won't make the bot red will it? If so, one option is to
mark them skip, just to make sure we can get the bot turned on as quickly
as possible.
On Fri, Dec 14, 2018 at 10:56 AM Stella Stamenova
wrote:
> It’s actually not green – the unexpected passes are counted as a failure.
It’s actually not green – the unexpected passes are counted as a failure. With
Pavel’s change to add the gcc builder, most of those can now be enabled, so I
am going to do that today, but there’s still a couple that are “unexpectedly
passing” when they are in fact failing. We’ll need to fix that
I've fixed it. It looks like the bot should be green again once this test
starts passing. Can you make it noisy and starting to send emails now?
On Fri, Dec 14, 2018 at 10:42 AM Zachary Turner wrote:
> Ahh, that seems easy enough to fix. Just need to change the 7 to a
> {{.*}}. Since we're a
Ahh, that seems easy enough to fix. Just need to change the 7 to a
{{.*}}. Since we're actually compiling and running a process on the
buildbot, different versions of Windows will affect this.
On Fri, Dec 14, 2018 at 10:39 AM Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> wrote:
>
stella.stamenova added a comment.
$ ":" "RUN: at line 5"
$ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S"
"E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f"
"E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\lo
I can't access the buildbot right now, it's just timing out and never
loading the webpage. If you have it open and can paste the output here I
can try to figure out what's wrong, otherwise I'll have to wait for it to
become available again.
On Fri, Dec 14, 2018 at 10:31 AM Stella Stamenova via Ph
stella.stamenova added a comment.
local-variables.cpp is failing on the Buildbot:
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2255/steps/test/logs/stdio
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55575/new/
https://reviews.llvm.org/D5557
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB349067: [NativePDB] Add support for local variables.
(authored by zturner, committed by ).
Herald added subscribers: te
labath added a comment.
The test looks really good now.
This looks fine to me, though I don't know much about PBDs. I still think the
seemingly random change in `BinaryStreamArray` would be better served as a
standalone patch.
Comment at: lldb/lit/SymbolFile/NativePDB/Inputs
zturner updated this revision to Diff 177877.
zturner added a comment.
Updated test to be less dependent on the exact format of the source.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55575/new/
https://reviews.llvm.org/D55575
Files:
lldb/lit/SymbolFile/NativePDB/Inputs/local-varia
labath added inline comments.
Comment at: lldb/lit/SymbolFile/NativePDB/local-variables.cpp:31-37
+// CHECK-NEXT:14 }
+// CHECK-NEXT:15
+// CHECK-NEXT:16 int main(int argc, char **argv) {
+// CHECK-NEXT: -> 17 int SomeLocal = argc * 2;
+// CHECK-NEXT:18
zturner marked an inline comment as done.
zturner added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1929
+}
+#include "lldb/Target/MemoryRegionInfo.h"
+CompilerDeclContext
labath wrote:
> Huh?
Oops :-/
CHANGES
zturner marked an inline comment as done.
zturner added inline comments.
Comment at: lldb/lit/SymbolFile/NativePDB/local-variables.cpp:31-37
+// CHECK-NEXT:14 }
+// CHECK-NEXT:15
+// CHECK-NEXT:16 int main(int argc, char **argv) {
+// CHECK-NEXT: -> 17 int Som
labath added inline comments.
Comment at: lldb/lit/SymbolFile/NativePDB/local-variables.cpp:31-37
+// CHECK-NEXT:14 }
+// CHECK-NEXT:15
+// CHECK-NEXT:16 int main(int argc, char **argv) {
+// CHECK-NEXT: -> 17 int SomeLocal = argc * 2;
+// CHECK-NEXT:18
zturner created this revision.
zturner added reviewers: labath, lemo, aleksandr.urakov, amccarth, clayborg,
leonid.mashinskiy.
Herald added subscribers: JDevlieghere, aprantl.
This patch adds support for parsing and evaluating local variables. using the
native pdb plugin.
While implementing thi
17 matches
Mail list logo
