labath added a comment. The test looks really good now.
This looks fine to me, though I don't know much about PBDs. I still think the seemingly random change in `BinaryStreamArray` would be better served as a standalone patch. ================ Comment at: lldb/lit/SymbolFile/NativePDB/Inputs/local-variables.lldbinit:19-22 +p Param1 +p Param2 +p Local1 +p Local2 ---------------- I am not sure if you care about the distinction between "expr" and "frame variable" here, but if you don't, these could be displayed in one shot with `frame variable Param1 Param2 Local1 Local2` (or even just `frame variable` which would display all locals). ================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1929 +} +#include "lldb/Target/MemoryRegionInfo.h" +CompilerDeclContext ---------------- zturner wrote: > labath wrote: > > Huh? > Oops :-/ It looks like you still haven't removed this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55575/new/ https://reviews.llvm.org/D55575 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
