[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-12-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 177598. JDevlieghere added a comment. - Rebase - Copy over permissions - Fix path when launching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 Files: include/lldb/Host/FileSystem.h include/lldb/U

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-29 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 176035. JDevlieghere added a comment. - Get the external path with modifying the VFS in LLVM. - Integrate with the new integration logic. - Add a test. (that doesn't work yet, still WIP) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D54617#1302376, @JDevlieghere wrote: > In https://reviews.llvm.org/D54617#1302366, @labath wrote: > > > I am confused by differing scopes of various objects that are interacting > > here. It seems you are implementing capture/replay as somethin

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-18 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In https://reviews.llvm.org/D54617#1302366, @labath wrote: > I am confused by differing scopes of various objects that are interacting > here. It seems you are implementing capture/replay as something that can be > flicked on/off at any point during a debug session

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I am confused by differing scopes of various objects that are interacting here. It seems you are implementing capture/replay as something that can be flicked on/off at any point during a debug session (`Debugger` lifetime). However, you are modifying global state (the fi

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. - Initialization of the FS needs to happen in the driver. - All file access has to go through the new FileSystem. - Needs tests. Repository: rLLDB LLDB https://reviews.llvm.org/D54617 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

2018-11-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. Herald added a subscriber: mgorny. JDevlieghere added a subscriber: labath. This patch is WIP and meant to showcase how the reproducer and VFS will interact. Repository: rLLDB LLDB https://reviews.llvm.org/D54617 Files: include/lldb/Host/FileSystem.h