JDevlieghere updated this revision to Diff 177598.
JDevlieghere added a comment.
- Rebase
- Copy over permissions
- Fix path when launching.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54617/new/
https://reviews.llvm.org/D54617
Files:
include/lldb/Host/FileSystem.h
include/lldb/U
JDevlieghere updated this revision to Diff 176035.
JDevlieghere added a comment.
- Get the external path with modifying the VFS in LLVM.
- Integrate with the new integration logic.
- Add a test. (that doesn't work yet, still WIP)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54617/new/
labath added a comment.
In https://reviews.llvm.org/D54617#1302376, @JDevlieghere wrote:
> In https://reviews.llvm.org/D54617#1302366, @labath wrote:
>
> > I am confused by differing scopes of various objects that are interacting
> > here. It seems you are implementing capture/replay as somethin
JDevlieghere added a comment.
In https://reviews.llvm.org/D54617#1302366, @labath wrote:
> I am confused by differing scopes of various objects that are interacting
> here. It seems you are implementing capture/replay as something that can be
> flicked on/off at any point during a debug session
labath added a comment.
I am confused by differing scopes of various objects that are interacting here.
It seems you are implementing capture/replay as something that can be flicked
on/off at any point during a debug session (`Debugger` lifetime). However, you
are modifying global state (the fi
JDevlieghere added a comment.
- Initialization of the FS needs to happen in the driver.
- All file access has to go through the new FileSystem.
- Needs tests.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54617
___
lldb-commits mailing list
ll
JDevlieghere created this revision.
Herald added a subscriber: mgorny.
JDevlieghere added a subscriber: labath.
This patch is WIP and meant to showcase how the reproducer and VFS will
interact.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54617
Files:
include/lldb/Host/FileSystem.h