labath added a comment.

I am confused by differing scopes of various objects that are interacting here. 
It seems you are implementing capture/replay as something that can be flicked 
on/off at any point during a debug session (`Debugger` lifetime). However, you 
are modifying global state (the filesystem singleton, at least), which is 
shared by all debug sessions. If multiple debug sessions try to enable 
capture/replay (or even access the filesystem concurrently, as none of this is 
synchronized in any way), things will break horribly. This seems like a bad 
starting point in implementing a feature, as I don't see any way to fix 
incrementally in the future.

Maybe you meant that by `Initialization of the FS needs to happen in the 
driver.`? In any case, for me the initialization part is the interesting/hard 
part of this problem. The details of how to collect the files are trivial 
compared to that and possibly depend on the result of the decisions made there.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54617



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to