[Lldb-commits] [PATCH] D47228: Break dependency from Core to ObjectFileJIT

2018-05-23 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL333143: Break dependency from Core to ObjectFileJIT. (authored by zturner, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47228?vs=148100&id=

[Lldb-commits] [PATCH] D47228: Break dependency from Core to ObjectFileJIT

2018-05-23 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The change sounds reasonable to me. I should just point out that this is the Core <-> ObjectFile**JIT** cycle you are breaking. Comment at: lldb/include/lldb/Core/Module.h:1

[Lldb-commits] [PATCH] D47228: Break dependency from Core to ObjectFileJIT

2018-05-22 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: labath, jingham. Herald added a subscriber: mgorny. This was responsible for the cycle Core > ObjectFile > Core. The only reason this dependency was here was so that `Module` could have a function called `CreateJITModule` which created thin