labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
The change sounds reasonable to me. I should just point out that this is the Core <-> ObjectFile**JIT** cycle you are breaking. ================ Comment at: lldb/include/lldb/Core/Module.h:165 + module_sp->m_objfile_sp = + std::make_shared<ObjFilePlugin>(module_sp, args...); + ---------------- std::forward<Args>(args)... ================ Comment at: lldb/source/Expression/IRExecutionUnit.cpp:35-36 #include "lldb/../../source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "lldb/../../source/Plugins/ObjectFile/JIT/ObjectFileJIT.h" ---------------- `#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h"` should work here https://reviews.llvm.org/D47228 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
