asmith added a comment.
Lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325188: Supply missing break in case statement. (authored by
amccarth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43215?vs=134252&id=1343
No
On Wed, Feb 14, 2018 at 2:46 PM Adrian McCarthy via Phabricator <
revi...@reviews.llvm.org> wrote:
> amccarth added a comment.
>
> Any remaining concerns?
>
>
> https://reviews.llvm.org/D43215
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.l
amccarth added a comment.
Any remaining concerns?
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth updated this revision to Diff 134252.
amccarth added a comment.
Per Aaron's suggestion, I ran the tests with an unconditional return (and an
assertion). There was no change in the test results, so I'm making this return
unconditionally.
https://reviews.llvm.org/D43215
Files:
lldb/
asmith added a comment.
That's a good question and I'm not sure. If all the tests pass you can make it
return unconditionally.
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
zturner added a reviewer: asmith.
zturner added a comment.
Aaron, do you remember why you added a check for `width == 0` here? Would it
ever not be 0?
https://reviews.llvm.org/D43215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
