[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth updated this revision to Diff 134252.
amccarth added a comment.

Per Aaron's suggestion, I ran the tests with an unconditional return (and an 
assertion).  There was no change in the test results, so I'm making this return 
unconditionally.


https://reviews.llvm.org/D43215

Files:
  lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp


Index: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
+++ lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
@@ -107,9 +107,7 @@
   case PDB_BuiltinType::None:
     return CompilerType();
   case PDB_BuiltinType::Void:
-    // FIXME: where is non-zero size of `void` from?
-    if (width == 0)
-      return clang_ast->GetBasicType(eBasicTypeVoid);
+    return clang_ast->GetBasicType(eBasicTypeVoid);
   case PDB_BuiltinType::Bool:
     return clang_ast->GetBasicType(eBasicTypeBool);
   case PDB_BuiltinType::Long:



Index: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
+++ lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
@@ -107,9 +107,7 @@
   case PDB_BuiltinType::None:
     return CompilerType();
   case PDB_BuiltinType::Void:
-    // FIXME: where is non-zero size of `void` from?
-    if (width == 0)
-      return clang_ast->GetBasicType(eBasicTypeVoid);
+    return clang_ast->GetBasicType(eBasicTypeVoid);
   case PDB_BuiltinType::Bool:
     return clang_ast->GetBasicType(eBasicTypeBool);
   case PDB_BuiltinType::Long:

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits